Bug 241403 - [commands][cache] isTargetAvailable logic should be outside the command cache
Summary: [commands][cache] isTargetAvailable logic should be outside the command cache
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.1   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-18 10:26 EDT by Marc Khouzam CLA
Modified: 2020-09-04 15:17 EDT (History)
2 users (show)

See Also:

Attachments
Patch with initial unit test for the data cache object. (5.39 KB, patch)
2008-09-30 18:08 EDT, Pawel Piech CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2008-07-18 10:26:02 EDT 
The command cache provides a way to track if a command can be sent to the target.  However, some commands are sent directly to the command control without using the cache.  Those commands lose the isTargetAvailable check.

This availability logic should be moved out to allow all commands to benefit from it.  In a meeting, Pawel mentioned an idea of a CommandControlProxy class to handle multiple commandControls; this class would be good place to move the availability logic.
Comment 1 Pawel Piech CLA 2008-09-30 18:08:15 EDT 
Created attachment 113930 [details]
Patch with initial unit test for the data cache object.
Comment 2 Marc Khouzam CLA 2008-10-03 11:18:11 EDT 
(In reply to comment #1)
> Created an attachment (id=113930) [details]
> Patch with initial unit test for the data cache object.

I guess there is a DataCache() patch that will come later?
Comment 3 Marc Khouzam CLA 2008-10-03 11:23:09 EDT 
(In reply to comment #1)

> I guess there is a DataCache() patch that will come later?

Sorry, I found it in bug 249236
Comment 4 Pawel Piech CLA 2008-10-03 12:42:53 EDT 
Comment on attachment 113930 [details]
Patch with initial unit test for the data cache object.

Oops, this patch was indeed intended for bug 249236.  Thanks Marc.