241345 – [formatter] Didn't Format HTML tags is unavailable

Bug 241345 - [formatter] Didn't Format HTML tags is unavailable

Summary: [formatter] Didn't Format HTML tags is unavailable

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Core (show other bugs)
Version:	3.4
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.4.1
Assignee:	Frederic Fusier
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-07-17 22:29 EDT by Lee
Modified:	2008-09-15 11:46 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
choose option (108.14 KB, image/pjpeg) 2008-07-17 22:29 EDT, Lee	no flags	Details
Proposed patch (3.61 KB, patch) 2008-08-19 12:11 EDT, Frederic Fusier	no flags	Details \| Diff
Proposed patch for R3_4_maintenance branch (3.90 KB, patch) 2008-08-20 06:17 EDT, Frederic Fusier	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lee

2008-07-17 22:29:09 EDT

Created attachment 107793 [details]
choose option

Build ID: I20080617-2000

Steps To Reproduce:
1.open Preferences
2.open JAVA->Code Style->Formatter, create a new active profile named Alie base on Eclipse [built in]->click edit and open Comments 
3. didn't choose Format HTML tags
4. open one java source code includes HTML tags
5. However, the HTML tags will be format.


More information:
In Preferences->JAVA->Code Style->Formatter->Comments, if I didn't choose "Format HTML tags", format the java source codes which includes HTML tags are unavailable. The Eclipse version is Ganymede. And in Eclipse 3.3, this option is available.

Comment 1 Frederic Fusier

2008-08-19 12:11:00 EDT

Created attachment 110357 [details]
Proposed patch

I missed to take this option into account while rewriting the comments formatter :-(
Fix is quite simple and the regression important, so I think this could be a good candidate for 3.4.1.
Jerome, do you agree?

Comment 2 Frederic Fusier

2008-08-19 12:17:05 EDT

Released for 3.5M2

Comment 3 Jerome Lanneluc

2008-08-19 12:29:21 EDT

+1 for 3.4.1

Comment 4 Frederic Fusier

2008-08-20 06:16:40 EDT

Reopen to fix in 3.4 maintenance stream

Comment 5 Frederic Fusier

2008-08-20 06:17:41 EDT

Created attachment 110425 [details]
Proposed patch for R3_4_maintenance branch

Comment 6 Frederic Fusier

2008-08-20 06:59:20 EDT

Released for 3.4.1 in R3_4_maintenance stream.

Comment 7 Olivier Thomann

2008-08-28 12:54:07 EDT

Verified for 3.4.1 using M20080827-2000

Comment 8 David Audel

2008-09-15 11:46:43 EDT

Verified for 3.5M2 using I20080914-2000