Bug 241075 - [run control] Revisit SteppingController and ISteppingControlParticipant
Summary: [run control] Revisit SteppingController and ISteppingControlParticipant
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2008-07-16 08:18 EDT by Anton Leherbauer CLA
Modified: 2020-09-04 15:22 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2008-07-16 08:18:08 EDT
From bug 214386 comment 14:

The ISteppingControlParticipant seems like a good idea, the only thing that
bothers me is that the contract where the participant needs to call
doneStepping() is rather vague.  I wish there was a way that the
SteppingController could call the participants when initiating the stepping,
which in turn would somehow obligate the participants to call doneStepping(). 
This doesn't really make sense though, because both the controller and the VM
adapter handle the data model events independently.  One option I though about
is to completely integrate the stepping controller into the
AbstractDebugVMAdapter.  But this would also force us to integrate the display
manager into the vm adapter, which could turn it into something of a mess.  On
the other hand it may help clarify the relationship between these.


Potential improvements for ISteppingControlParticipant to make the API contract 
more explicit:
- call participants with CountingRequestMonitor when a step command has been 
  issued
- query participants whether a step should be allowed
Comment 1 Pawel Piech CLA 2008-10-07 14:15:28 EDT
This is also something we'll need to look into before finalizing the debug view model API... in a future release.