Bug 241074 - [templates] HelloRCP template contains non-externalized strings
Summary: [templates] HelloRCP template contains non-externalized strings
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-07-16 07:52 EDT by Peter Friese CLA
Modified: 2009-07-29 03:55 EDT (History)
2 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2008-07-16 08:12 EDT, Peter Friese CLA 		contact: iplog+
Details | Diff
mylyn/context/zip (2.87 KB, application/octet-stream)
2008-07-16 08:12 EDT, Peter Friese CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Friese CLA 2008-07-16 07:52:09 EDT 
I20080715-1015

Steps to reproduce:
1) Create a new RCP project using the HelloRCP template
2) Ensure non-externalized strings are errors
3) You get errors for
   - hellorcp.ApplicationWorkbenchWindowAdvisor.preWindowOpen()
   - hellorcp.ApplicationWorkbenchAdvisor.PERSPECTIVE_ID
   - hellorcp.Activator.PLUGIN_ID
   
Those strings should probably ba marked //$NON-NLS-1$
Comment 1 Peter Friese CLA 2008-07-16 08:12:11 EDT 
Created attachment 107594 [details]
Patch

Added //$NON-NLS-1$ markers.
Comment 2 Peter Friese CLA 2008-07-16 08:12:14 EDT 
Created attachment 107595 [details]
mylyn/context/zip
Comment 3 Benjamin Cabé CLA 2009-07-29 03:55:27 EDT 
available in HEAD > 20090729

Thanks Peter!