Bug 240934 - Add support for the invokedynamic bytecode into the disassembler
Summary: Add support for the invokedynamic bytecode into the disassembler
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-15 14:03 EDT by Olivier Thomann CLA
Modified: 2009-08-10 15:44 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (8.67 KB, patch)
2009-06-09 14:58 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (8.98 KB, patch)
2009-06-12 13:44 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-07-15 14:03:22 EDT 
Once this is released, the disassembler needs to display it.
Comment 1 Olivier Thomann CLA 2009-06-09 14:58:46 EDT 
Created attachment 138708 [details]
Proposed fix

I still need to add regression tests.
Comment 2 Olivier Thomann CLA 2009-06-12 13:44:12 EDT 
Created attachment 139054 [details]
Proposed fix

Use null instead of an empty char array for the declaring class
Comment 3 Olivier Thomann CLA 2009-07-28 10:17:15 EDT 
Released for 3.6M1.
Comment 4 Frederic Fusier CLA 2009-08-05 05:36:57 EDT 
Code looks ok, hence set as verified for 3.6M1.

However, Olivier, it would be nice to add tests asap and give some clues to help to verify that it really works properly, thx
Comment 5 Olivier Thomann CLA 2009-08-10 15:44:36 EDT 
It is difficult to add a regression test as long as this is not included in a JDK.
Once I can easily built such a .class file, I'll add a test for it.