Community
Participate
Working Groups
I am unable to edit the auto-generated IP log for either Equinox or the Eclipse Platform project. I am a committer on both projects, and when I get directed to log in through friends of Eclipse I am able to successfully login. I am only viewing the IP log for one project at a time. Based on the info on the wiki page, the other possibility is that the foundation has a different email address on record for me than my bugzilla email.
You can check the email address that the Foundation database has for you via the portal. You already know the email address that bugzilla uses for you because you use that to login. Do these two emails match? What email address are you logging in with on the Friends of Eclipse page? I tested the ip_log.php again and the login is working for me so the code is obviously working.
I confirmed the email addresses are the same. I also asked DJ to try it to ensure it wasn't just an issue with my account. It looks to me like it's not recognizing the login. I click the "login" button on the left hand side of the page. After going through the login successfully, I click "Return to previous page", and it takes me back to the IP log page. Back on the IP log page, I can still see the "login" button on the left hand side, which suggests to me that it doesn't know I'm logged in. DJ sees the same behaviour. Note that we are not "friends of eclipse", if that makes a difference.
To answer the other question in comment #1, I'm logging in with "john_arthorne@ca.ibm.com", which matches my bugzilla email and the email address in the portal.
Same here. I follow the login link, enter my credentials and login successfully. But when I click "Return to previous page" the IP Log still says that I need to login. I've verified that my bugzilla e-mail address is the says as the address in portal.
From a quick poll of other committers on #eclipse-dev, it only seems to work for people who are friends of eclipse. So, I guess I need to pay you to keep my IP log up to date ;)
Denis - could you look into this? It's supposed to work for anyone, not just Friends even though it uses the Friends login.
That or there should be a login page for Casual Acquaintances of Eclipse
> Denis - could you look into this? Sure .. where is the code, or what's the URL?
(In reply to comment #8) > Sure .. where is the code, or what's the URL? http://www.eclipse.org/projects/ip_log.php?projectid=eclipse.equinox
(In reply to comment #6) > Denis - could you look into this? It's supposed to work for anyone, not just > Friends even though it uses the Friends login. > Here is the faulty code: if( $Friend->getFriendID() == 0 ) { If you simply want to verify for a logged in user (Friend or not) change that to: if( $Session->getBugzillaID() == 0 ) { If you need to check for a committer, that code is not there yet, but I can hack it in real quick. Also, I added: header("Cache-control: no-cache"); As newly logged-in folks would get the stale page upon hitting Return To Previous Page.
I changed the code a la Denis' guidance (comment #10). I am unable to test if this solves the problem because I never experienced the problem using my own login. I am assuming that the problem is solved. Please reopen (with details) if the problem still exists. Sorry about my faulty code causing you trouble and thanks for your patience.
I still can't edit the log. The difference now is that I see this message at the bottom of the IP log page after logging in: internal error 2: no bugzilla_id for friend_id
Also from comment #10, Denis suggests there is no way to currently check for a logged in committer. Since we presumably don't want everyone with a bugzilla id to be able to edit IP logs, doesn't this support need to be added?
(In reply to comment #13) > Also from comment #10, Denis suggests there is no way to currently check for a > logged in committer. Since we presumably don't want everyone with a bugzilla id > to be able to edit IP logs, doesn't this support need to be added? The code does check this. It only works for project leads, pmc members and leads, and committers on the project as far as I can tell.
Ok, I think (for the second time) that I've fixed this. It's a bit hard to test for the failure because it always seems to work for me, but I did find a second place in the code that might have been the cause. I'm marking as FIXED again, but of course REOPEN it if I am wrong again.
Works for me now, thanks.
Closing.
