Description Alex Shatalin 2008-07-12 08:08:46 EDT

Following two edit helper advices are registered inside org.eclipse.gmf.runtime.diagram.core plugin:

<extension point="org.eclipse.gmf.runtime.emf.type.core.elementTypes">
   <metamodel nsURI="http://www.eclipse.org/emf/2002/Ecore">
      <adviceBinding
         class="org.eclipse.gmf.runtime.diagram.core.edithelpers.NotationViewDependentsAdvice"
         id="org.eclipse.gmf.runtime.diagram.core.advice.notationDepdendents"
         inheritance="none"
         typeId="*"/>
      <adviceBinding
         class="org.eclipse.gmf.runtime.diagram.core.edithelpers.RemoveBookmarksAdvice"
         id="org.eclipse.gmf.runtime.diagram.core.advice.removeBookmarks"
         inheritance="none"
         typeId="*"/>
   </metamodel>
</extension>

AFAIU both advices are registered for any elementTypes attached to "http://www.eclipse.org/emf/2002/Ecore" metamodel. The question is: why corresponding two advices are registered for this particular metamodel? We should either register these advices for all generated diargams (+metamodels) or remove this registration.

AFAIKSee both advices are rather geenric, so not sure which option should we follow.