Bug 240214 - [compiler] final bit should be cleared from class file access flag for anonymous class
Summary: [compiler] final bit should be cleared from class file access flag for anonym...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-09 14:28 EDT by Olivier Thomann CLA
Modified: 2008-09-15 12:18 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (879 bytes, patch)
2008-07-10 11:52 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-07-09 14:28:10 EDT 
Right now we report anonymous access flag as final at the class file level, but the access flag of the corresponding anonymous type entry has be set to default (0) inside the inner class info. See bug 162296.
For consistency, we should also clear the bit for the class file access flag.
Comment 1 Philipe Mulet CLA 2008-07-10 05:24:43 EDT 
+1, also please fix in all affected streams.
Comment 2 Olivier Thomann CLA 2008-07-10 11:52:22 EDT 
Created attachment 107095 [details]
Proposed fix
Comment 3 Olivier Thomann CLA 2008-07-10 14:14:22 EDT 
Released for 3.5M1.
Comment 4 Olivier Thomann CLA 2008-07-10 14:14:43 EDT 
Released for 3.4.1
Comment 5 Olivier Thomann CLA 2008-07-10 14:20:58 EDT 
Added regression test org.eclipse.jdt.core.tests.compiler.regression.InnerEmulationTest#test155 for all streams (HEAD and 3.4.1).
Comment 6 Olivier Thomann CLA 2008-07-10 15:30:42 EDT 
Backported to 3.2.x with regression test org.eclipse.jdt.core.tests.compiler.regression.InnerEmulationTest#test135
Comment 7 Olivier Thomann CLA 2008-07-10 15:34:51 EDT 
Backported to 3.3.x with regression test org.eclipse.jdt.core.tests.compiler.regression.InnerEmulationTest#test153
Comment 8 Kent Johnson CLA 2008-08-06 12:42:03 EDT 
Verified for 3.5M1 using I20080805-1307
Comment 9 Jerome Lanneluc CLA 2008-08-28 12:42:07 EDT 
To reproduce, I undid Olivier's change in a 3.4.x workspace and I ran InnerEmulationTest.

Verified for 3.4.1 using M20080827-2000
Comment 10 Jerome Lanneluc CLA 2008-09-15 11:54:35 EDT 
Changing resolution back to FIXED since as per JDT/Core process a bug is marked VERIFIED only when verified in all streams.
Comment 11 Jerome Lanneluc CLA 2008-09-15 12:18:29 EDT 
Actually, after talking with Frederic, our verification process (ie. the FAQ) needs to be updated to say that a bug doesn't need to be verified if no official release is planned.