Bug 240068 - [ds] IConstants and IDSConstants duplicate entries
Summary: [ds] IConstants and IDSConstants duplicate entries
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Rafael Oliveira Nóbrega CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-07-08 15:41 EDT by Chris Aniszczyk CLA
Modified: 2008-07-24 15:40 EDT (History)
0 users

See Also:

Attachments
Constants fixed (1/2) (20.38 KB, text/plain)
2008-07-24 11:39 EDT, Rafael Oliveira Nóbrega CLA 		caniszczyk: iplog+
Details
Constants fixed (2/2) (5.85 KB, text/plain)
2008-07-24 11:40 EDT, Rafael Oliveira Nóbrega CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-07-08 15:41:39 EDT 
There's stuff in IConstants that should be in IDSContants... there's duplicate information. For example, the property types and cardinality stuff should be in IDSConstants already and referenced properly.
Comment 1 Chris Aniszczyk CLA 2008-07-08 15:45:43 EDT 
This is all yours Rafael ;)
Comment 2 Rafael Oliveira Nóbrega CLA 2008-07-08 15:55:49 EDT 
So, We should use IDSConstant (from ds.core) as default, and IConstant (from ds.ui) when we don't have this information in IDSConsntant?
Comment 3 Chris Aniszczyk CLA 2008-07-08 15:56:13 EDT 
exactly.
Comment 4 Chris Aniszczyk CLA 2008-07-21 17:07:54 EDT 
poke :)
Comment 5 Chris Aniszczyk CLA 2008-07-24 10:50:01 EDT 
Want to finish this one up Rafael? Should be simple.
Comment 6 Rafael Oliveira Nóbrega CLA 2008-07-24 11:23:17 EDT 
Chris,

could you please apply the patch of bug ~239495, so I will attach a patch for this one.

Cheers,
Comment 7 Rafael Oliveira Nóbrega CLA 2008-07-24 11:39:54 EDT 
Created attachment 108365 [details]
Constants fixed (1/2)
Comment 8 Rafael Oliveira Nóbrega CLA 2008-07-24 11:40:22 EDT 
Created attachment 108366 [details]
Constants fixed (2/2)
Comment 9 Chris Aniszczyk CLA 2008-07-24 12:09:32 EDT 
Rafael, the 2nd patch didn't apply cleanly.
Comment 10 Rafael Oliveira Nóbrega CLA 2008-07-24 13:47:10 EDT 
Chris,

I didn`t notice any problem here. Can you describe the problem that you have seen?

Cheers,
Comment 11 Chris Aniszczyk CLA 2008-07-24 15:06:01 EDT 
It doesn't let me apply the second patch cleanly... there's some conflicts maybe with another patch?
Comment 12 Rafael Oliveira Nóbrega CLA 2008-07-24 15:21:00 EDT 
Chris, 

didn`t you apply the last patch?

Because I have no problems or unsync code here.

Any idea?

Cheers,
Comment 13 Chris Aniszczyk CLA 2008-07-24 15:40:25 EDT 
looks good to me now, didn't see any issues for some reason apply patch thought there were conflicts when things were already applied... *sigh*