Bug 240000 - Splash templates generate bad NON-NLS comments
Summary: Splash templates generate bad NON-NLS comments
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-07-08 11:00 EDT by Kim Horne CLA
Modified: 2008-07-16 09:40 EDT (History)
2 users (show)

See Also:

Attachments
Patch with "escaped" $ signs (2.31 KB, patch)
2008-07-16 07:43 EDT, Peter Friese CLA 		curtis.windatt.public: iplog+
Details | Diff
mylyn/context/zip (925 bytes, application/octet-stream)
2008-07-16 07:43 EDT, Peter Friese CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2008-07-08 11:00:55 EDT 
I20080624-0800

Create a rcp project
Ensure that unexternalized strings are errors
Create a new product file
In the product file, add an interactive splash template
Synchronize the product
Note that the generated class has errors - the NON-NLS tags are not valid (they're missing $'s)
Comment 1 Chris Aniszczyk CLA 2008-07-08 11:10:12 EDT 
you're a stickler Kim :)
Comment 2 Kim Horne CLA 2008-07-08 11:13:29 EDT 
I hate red squiggles!  Hate!
Comment 3 Peter Friese CLA 2008-07-16 07:08:52 EDT 
<rcpproject>.ApplicationWorkbenchAdvisor.PERSPECTIVE_ID and <rcpproject>.Activator.PLUGIN_ID also need NON-NLS tags.
Comment 4 Peter Friese CLA 2008-07-16 07:43:39 EDT 
Created attachment 107592 [details]
Patch with "escaped" $ signs

The problem is that the "template engine" thinks $NON-NLS-1$ is a variable :-) I see various fixes for this problem:
a) insert double $ signs: //$$NON-NLS-1$$
b) fix the template engine so it can deal with $NON-NLS$
c) use a real template engine :-P

I chose option (a) since it the fastest way to success. However, as options (b) and (c) are more sustainable, I am always happy to discuss.
Comment 5 Peter Friese CLA 2008-07-16 07:43:42 EDT 
Created attachment 107593 [details]
mylyn/context/zip
Comment 6 Curtis Windatt CLA 2008-07-16 09:40:06 EDT 
Fix is good, thanks for the contribution.
Comment 7 Curtis Windatt CLA 2008-07-16 09:40:50 EDT 
Applied patch to HEAD.