Bug 239894 - Use of Projector.getApplicationPatches could be more efficient
Summary: Use of Projector.getApplicationPatches could be more efficient
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 238312
  Show dependency tree
 
Reported: 2008-07-07 17:54 EDT by Simon Kaegi CLA
Modified: 2008-08-08 01:46 EDT (History)
0 users

See Also:

Attachments
patch (2.39 KB, patch)
2008-07-15 23:45 EDT, Simon Kaegi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2008-07-07 17:54:54 EDT 
In Projector.processIU we end up looking for patches for each IU. This ends up looking at all IUs found by the picker for a patch. We could be smarter here and pre-filter for just the patches before calling getApplicationPatches.

See:
Projector.processIU (line 300)
Comment 1 Simon Kaegi CLA 2008-07-10 09:52:57 EDT 
The primary motivation for doing changes here is to improve performance. In doing profiling this call never took more than one or two percent of the total time so we can likely defer this change for now.
Comment 2 Simon Kaegi CLA 2008-07-15 23:45:12 EDT 
Created attachment 107562 [details]
patch
Comment 3 Simon Kaegi CLA 2008-07-16 15:17:52 EDT 
patch committed to HEAD. Leaving open to wait and see on bug 238312
Comment 4 Simon Kaegi CLA 2008-08-08 01:46:01 EDT 
Marking fixed along with bug 238312