Bug 239409 - JPA Entity wizard second page should show the fully qualified name of the attribute type
Summary: JPA Entity wizard second page should show the fully qualified name of the att...
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Neil Hauge CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-07-03 04:55 EDT by kiril mitov CLA
Modified: 2008-11-20 12:10 EST (History)
4 users (show)

See Also:

Attachments
the type of added field is with fully qualified name in the table (1.11 KB, patch)
2008-08-07 10:17 EDT, Dimiter Dimitrov CLA 		neil.hauge: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kiril mitov CLA 2008-07-03 04:55:08 EDT 
Build id: I20080617-2000

Create a new EJB 3.0 project.
Add JPA facet to the project.
Start the jpa entity wizard.
Add correct values for the first page.
Move to the second page.
Press Add for adding new field.
A dialog is opened. 
For the type of the field TYPE (do not select) "String". For the name of the field type field1.
Add another field.
For the type of the field select from the combo box "java.lang.String". For the name of the field type field2.

Now on the second page in the "Entity Fields" table both fields are shown. The first field is of type "String" and can not be selected in the checkbox. The second field is again of type "String", but it CAN be selected in the checkbox.
This is because the second field is actually of type java.lang.String. 
But only String is shown in the type column.

My proposal will be to show the fully qualified name of the type in the Type column.
Comment 1 Dimiter Dimitrov CLA 2008-08-07 10:17:03 EDT 
Created attachment 109408 [details]
the type of added field is with fully qualified name in the table
Comment 2 Neil Hauge CLA 2008-10-23 17:51:47 EDT 
This seems reasonable, since the tooltip does a good job of displaying names too large from the column.

Patch committed.
Comment 3 Neil Hauge CLA 2008-10-23 17:52:08 EDT 
Committed.
Comment 4 Karen Butzke CLA 2008-11-20 12:10:36 EST 
verified in current code