Bug 238943 - SortElementsOperation doesn't use project specific settings
Summary: SortElementsOperation doesn't use project specific settings
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-30 04:42 EDT by Martin Aeschlimann CLA
Modified: 2009-10-27 07:24 EDT (History)
3 users (show)

See Also:

Attachments
patch (1.51 KB, patch)
2008-06-30 04:53 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
Proposed fix (1.09 KB, patch)
2009-09-17 14:10 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-06-30 04:42:53 EDT 
3.4

SortElementsOperation is using the workspace settings instead of project settings.
See line 140 in SortElementsOperation.calculateEdit(CompilationUnit, TextEditGroup)
Comment 1 Martin Aeschlimann CLA 2008-06-30 04:53:46 EDT 
Created attachment 106097 [details]
patch

I suggest to release this also for 3.4.1 as it is a simple fix that helps to avoid confusion about the sort member operation. (for example how it is indenting and if it uses tab or space)
Comment 2 Jerome Lanneluc CLA 2008-07-02 07:52:51 EDT 
Can you please provide a scenario (including the exact project preference that is not taken into account) so that we can evaluate if it is worth adding to 3.4.1?
Comment 3 Olivier Thomann CLA 2009-09-17 14:10:18 EDT 
Released for 3.6M3.
Code verification is required to verify this fix. I'll update the patch.
Comment 4 Olivier Thomann CLA 2009-09-17 14:10:52 EDT 
Created attachment 147472 [details]
Proposed fix

Updated patch.
Comment 5 Olivier Thomann CLA 2009-09-17 14:11:21 EDT 
Released.
Comment 6 Jay Arthanareeswaran CLA 2009-10-26 23:46:04 EDT 
Verified for 3.6M3 by code inspection.