Community
Participate
Working Groups
Since multiple matching engines can apply to a selection of models (i.e. by defining the same fileExtension value), it would be useful to have a dialog through which the user can specify which matching engine is to be used in a particular comparison. Moreover, in order not to be disruptive to the user, it would be nice if Compare "remembered" the last selected matching engine for a particular pair, and provided an option like "Compare with..." to let the user change it (similarly to the Open, Open With behaviour for files)
Created attachment 105912 [details] Patch for org.eclipse.emf.compare.ui
Created attachment 105913 [details] Patch for org.eclipse.emf.compare.match
I've attached patches that resolve this issue. I haven't added copyright notices; EMF Compare developers please free to add them as you see fit.
Thanks again Dimitrios, that will be our first contribution for the 0.9 branch :) Cédric
Thanks for your hard work on EMF Compare and for making it so modular. NB: The patches do not implement the same feature for diff engines and merge engines. I'll probably implement them soon as I continue exploring EMF Compare in more detail (unless you beat me to that and implement them first :)).
I was expecting to have this issue in my TODO list soon, yet we're more than happy to get contributions ;). Thanks a lot for your feedback and involvement.
Changed version to 0.9 since this will modify the API (especially the engines extension point).
Dimitrios, Sorry I couldn't take a closer look at those patches sooner. I applied them on HEAD (0.8 maintenace branch has been created at last \o/). A few things I did/could not let as-is though : - I added a copyright on all files created by your patch and stated you as the author (I've added mailto: links to the mail you use here) - The match engines extension point documentation states that file extensions are "comma separated". Your code assumed a semicolon as the separator, I modified this back. - Changed the IMatchEngineSelector to take a Set instead of a List. We know there cannot be duplicates, this will avoid the checks overhead. Note that this contribution is considered an API break since the matchengine extension point now has a "label" required attribute. Thanks again for your involvement!
FIX available in 0.9.0M4.
cleaning up the IP log by removing the iplog+ on the bug but adding it on the patches. sorry for the mail bombinb involved here :/
Closing our "resolved" and "verified" bugs.
