Bug 238419 - [disassembly] DisassemblyDocument does not compile
Summary: [disassembly] DisassemblyDocument does not compile
Status: CLOSED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 0 DD 1.1   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: DD 1.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-25 10:56 EDT by Marc Khouzam CLA
Modified: 2009-01-07 17:29 EST (History)
2 users (show)

See Also:

Attachments
Fix (+committed) (1.24 KB, patch)
2008-06-25 11:11 EDT, Anton Leherbauer CLA 		pawel.1.piech: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2008-06-25 10:56:46 EDT 
Bug 238108 made the compiler more strict about using variables that are null.  That was a good change.  However, DisassemblyDocument.java no longer compiles because it has a code error that uses a null variable.

I'm not familiar with that code (and was too lazy to dive into it :-)) so I didn't know how to fix it.

This is on HEAD.
Comment 1 Anton Leherbauer CLA 2008-06-25 11:11:48 EDT 
Created attachment 105816 [details]
Fix (+committed)

Hm, the error appeared only after a clean build.
Comment 2 Marc Khouzam CLA 2008-06-25 11:15:05 EDT 
(In reply to comment #1)
> Created an attachment (id=105816) [details]
> Fix

Thanks.
Are you all setup to commit it yourself or do you need me to do it?
Comment 3 Anton Leherbauer CLA 2008-06-25 11:17:45 EDT 
(In reply to comment #2)
> Are you all setup to commit it yourself or do you need me to do it?

I don't think I have full commit rights yet. Please commit.
Comment 4 Marc Khouzam CLA 2008-06-25 11:23:53 EDT 
Committed Toni's patch.
Comment 5 Marc Khouzam CLA 2008-06-25 11:24:42 EDT 
Fixed.
Toni, can you verify?
Comment 6 Anton Leherbauer CLA 2008-06-25 11:34:08 EDT 
Verified.
Comment 7 Pawel Piech CLA 2009-01-07 15:56:08 EST 
DD 1.1 reelased!