Bug 238257 - Request a help text when no tab is open in the "Terminals" view
Summary: Request a help text when no tab is open in the "Terminals" view
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0.1   Edit
Assignee: Anna Dushistova CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: PII
Depends on:
Blocks: 244429
  Show dependency tree
 
Reported: 2008-06-24 10:49 EDT by Martin Oberhuber CLA
Modified: 2008-08-18 14:10 EDT (History)
3 users (show)

See Also:


Attachments
patch that sets help text for terminal view (3.84 KB, patch)
2008-08-06 11:57 EDT, Anna Dushistova CLA
no flags Details | Diff
patch that sets help text for terminals, shells and monitor views (10.51 KB, patch)
2008-08-11 07:38 EDT, Anna Dushistova CLA
mober.at+eclipse: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-06-24 10:49:05 EDT
From bug 237425: Doing 

   Window > Show View > Other > Remote Systems > Remote Shell

shows an empty, gray view since the view is not yet filled with any context. Similar to the "Window > Show View > Other > Java > Call Hierarchy" view, some help text should be displayed in the empty view, that explains why the view is empty and how to populate.

This will require PII, but since an untranslated String is better than no String at all I'd think we can accomodate this in the TM 3.0.1 branch - Dave, Xuan, what do you think about this?
Comment 1 Anna Dushistova CLA 2008-08-01 04:43:59 EDT
(In reply to comment #0)
> From bug 237425: Doing 
> 
>    Window > Show View > Other > Remote Systems > Remote Shell
> 
> shows an empty, gray view since the view is not yet filled with any context.
> Similar to the "Window > Show View > Other > Java > Call Hierarchy" view, some
> help text should be displayed in the empty view, that explains why the view is
> empty and how to populate.
> 

Martin, can you be more concrete in what such a text should say? 

Comment 2 Anna Dushistova CLA 2008-08-06 11:57:43 EDT
Created attachment 109328 [details]
patch that sets help text for terminal view

Could you please review this patch and the text for terminals view? If it's fine, I'll do the same for other views.
Comment 3 Anna Dushistova CLA 2008-08-11 07:38:19 EDT
Created attachment 109653 [details]
patch that sets help text for terminals, shells and monitor views
Comment 4 Xuan Chen CLA 2008-08-11 11:37:46 EDT
Anna,
Sorry for the delay of the reply for your question.

I was wondering if you could just change the one for the terminal view, since the other two will affect us.  We translated our driver to different languages, and it is way past our NLS deadline now.
Comment 5 Anna Dushistova CLA 2008-08-11 12:15:25 EDT
(In reply to comment #4)
> Anna,
> Sorry for the delay of the reply for your question.
> 
> I was wondering if you could just change the one for the terminal view, since
> the other two will affect us.  We translated our driver to different languages,
> and it is way past our NLS deadline now.
> 

Yes, I can do only terminal view for now.
Comment 6 Anna Dushistova CLA 2008-08-11 12:46:55 EDT
I checked in the fix for terminals view.
Comment 7 Martin Oberhuber CLA 2008-08-18 10:54:20 EDT
I have forked out the request for "Remote Shell" and "Remote Monitor" into bug 244429 such that we can get this one closed. Summary updated accordingly.

I'm not sure if the text is correct PII, it might be that the single-quotes need to be quoted, Xuan can you check this please in 

  org.eclipse.rse.terminals.ui / TerminalUIResources.properties:

TerminalViewer_text=To open a terminal, right-click the Terminal subsystem under the target. Then select 'Launch Terminal' from the context menu.

I'm also not sure if this text is informative enough. What about this:

TerminalViewer_text=To open a terminal, open the Remote Systems view. Right-click the Terminal subsystem under the connection to use. Then select 'Launch Terminal' from the context menu.
Comment 8 Anna Dushistova CLA 2008-08-18 14:10:44 EDT
Fix is in CVS already.