Bug 237803 - ConnectionEditPart.refreshBendpoints creates precision errors
Summary: ConnectionEditPart.refreshBendpoints creates precision errors
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.1.2   Edit
Assignee: Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-19 11:37 EDT by Stéphane Lizeray CLA
Modified: 2010-07-19 21:59 EDT (History)
2 users (show)

See Also:

Attachments
use double precision for the setting the weight (1010 bytes, patch)
2008-06-19 11:37 EDT, Stéphane Lizeray CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Lizeray CLA 2008-06-19 11:37:15 EDT 
Created attachment 105425 [details]
use double precision for the setting the weight

Build ID: I20080530-1730

Steps To Reproduce:
1.
2.
3.


More information:
use double precision for setting the weight of the relative bendpoints.
Comment 1 Stéphane Lizeray CLA 2008-06-19 11:39:09 EDT 
see bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=237802
Comment 2 Alex Boyko CLA 2008-09-08 13:08:30 EDT 
Anthony, do you mind if I commit this patch for 2.1.2? It looks good to me.
Comment 3 Alex Boyko CLA 2008-09-08 13:11:59 EDT 
Actually, since #setWeight(float) still works with floats, not sure if we need this to be committed at all.
Comment 4 Anthony Hunter CLA 2008-09-11 09:08:05 EDT 
(In reply to comment #3)
> Actually, since #setWeight(float) still works with floats, not sure if we need
> this to be committed at all.
> 

Can you comment? Alex / Stephane?
Comment 5 Stéphane Lizeray CLA 2008-09-11 10:01:05 EDT 
Yes, the bug is fixed by the fix in RelativeBendpoint (237802). So we can leave the setWeigth method with a float parameter even though I think that it is better to work only with double precision for the implementations of the Bendpoint interface.


Thanks a lot for your help
Comment 6 Alex Boyko CLA 2008-09-11 12:28:07 EDT 
Fixed indirectly
Comment 7 Eclipse Webmaster CLA 2010-07-19 21:59:31 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug