Community
Participate
Working Groups
Build ID: 3.4 Steps To Reproduce: 1.please put it on the babel server 2. 3. More information: Japanese language pack for Ganymede from Japan WG. This is based on automatic translation by Pleiades translation engine and blancoNLpackGenerator. And it is built along the guide line of "Contributing large translations sets to Babel"
I think you forgot the attachment :-)
I tried again and got the error message of "too large file." So, please pick the zip file file from the following URL. http://sourceforge.jp/projects/blancofw/files/?release_id=31592#31592 -> NLpackja-eclipse-ganymede-babel-largecontribution-blancofw20080617.zip
The contribution will need to be reviewed by Eclipse Legal, and IPZilla supports file uploads up to 30MB, so I have downloaded the file and attached it there. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2441
Mori-san, I have an action item for you. The Eclipse Legal team sais: Can you please go ahead and arrange for the contributor to have the Eclipse Employer Consent signed by the employer NEC. While NEC is a member of Eclipse, they have not signed a Member Committer Agreement - here is the link to the document - http://www.eclipse.org/legal/committer_process/employer_consent.pdf. If you have any questions, please let me know.
I have received Mori-san's ECF and have forwarded it to the IP Team. They will proceed with their review.
The contribution has been approved. I'll work on importing it into the server today.
Flagging for iplog.
I've imported this into the Staging server. The import completed with about 65,000 strings: http://babel.eclipse.org/staging/recent.php Please have a look. Kit, please +1 for importing this live.
We (Japanese translators) are going to check it. Thanks a lot.
I have one question about this string: http://babel.eclipse.org/staging/translate.php?project=eclipse&version=3.4&file=org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties&string=SampleEditor_content <a href\="run"> We have an extra backslash in front of the equal sign in the translation. Was it added during translation? Or, was it added during importing? We shouldn't need to escape the equal sign in HTML tags. This may cause problems when displaying this HTML segment in a browser.
Here is the actual translation in the file: SampleEditor_content=<form><p><b>\u30B5\u30F3\u30D7\u30EB\u3067\u5B9F\u884C\u3067\u304D\u308B\u30A2\u30AF\u30B7\u30E7\u30F3</b></p><li>\u30EF\u30FC\u30AF\u30B9\u30DA\u30FC\u30B9\u5185\u306E\u30BD\u30FC\u30B9\u30FB\u30B3\u30FC\u30C9\u3092\u53C2\u7167\u3057\u307E\u3059\u3002</li><li>\u6E96\u5099\u304C\u3067\u304D\u305F\u3089\u3001<a href\="run">\u30B5\u30F3\u30D7\u30EB\u3092\u5B9F\u884C</a>\u3057\u3001<img href\="help"/><a href\="help">\u30D8\u30EB\u30D7\u6587\u66F8</a>\u306E\u6307\u793A\u306B\u5F93\u3044\u307E\u3059\u3002</li><li>\u5F8C\u3067\u3001\u30C4\u30FC\u30EB\u30D0\u30FC\u4E0A\u306E<img href\="run"/><b>\u5B9F\u884C</b>\u30A2\u30A4\u30B3\u30F3\u3092\u62BC\u3057\u3066\u30B5\u30F3\u30D7\u30EB\u3092\u518D\u5B9F\u884C\u3059\u308B\u3053\u3068\u304C\u3067\u304D\u307E\u3059\u3002</li><li>\u30B3\u30FC\u30C9\u5185\u306B\u30D6\u30EC\u30FC\u30AF\u30DD\u30A4\u30F3\u30C8\u3092\u914D\u7F6E\u3057\u305F\u5834\u5408\u306F\u3001\u3053\u308C\u3092<a href\="debug">\u30C7\u30D0\u30C3\u30B0</a>\u3059\u308B\u3053\u3068\u304C\u3067\u304D\u307E\u3059\u3002</li><li>\u5F8C\u3067\u3001\u30C4\u30FC\u30EB\u30D0\u30FC\u4E0A\u306E<img href\="debug"/><b>\u30C7\u30D0\u30C3\u30B0</b>\u30FB\u30A2\u30A4\u30B3\u30F3\u3092\u62BC\u3057\u3066\u30B5\u30F3\u30D7\u30EB\u3092\u30C7\u30D0\u30C3\u30B0\u3059\u308B\u3053\u3068\u304C\u3067\u304D\u307E\u3059\u3002</li></form> I can see others as well: ProductDefinitonWizardPage_productDefinition=<form><p>\u30D6\u30E9\u30F3\u30C9\u306E Eclipse \u30E6\u30CB\u30C3\u30C8\u3067\u3042\u308B\u88FD\u54C1\u306F\u3001\u30D7\u30E9\u30B0\u30A4\u30F3\u5185\u306E <a href\="products">org.eclipse.core.runtime.products</a> \u62E1\u5F35\u5B50\u3068\u3057\u3066\u5BA3\u8A00\u7684\u306B\u5B9A\u7FA9\u3055\u308C\u307E\u3059\u3002</p></form>
Mori-san, can the JWG take a look to see if we could avoid adding the backslashes in this case? Thanks!
Kit-san, Thank you for your assistance. we are now checking.
Hi Kit-san and Denis-san, About bachslashes, we confirmed .properties files in our contribution, and found that it met the specification of java.util.Properties. So these backslashes should be removed in loading with some applicable escape treatment. Those can be loaded correctly by using java standard APIs. Could you check the loading method on the babel server side?
Kit-san and Denis-san, JWG found another point. Some spaces are removed like, a href -> ahref This may cause problems. According to the specification, spaces in .properties files should be handled correctly, even if it exists at the end of string.
I agree that if the calling client properly processes the escaped backslashes before displaying the HTML tags, the translations should not be a problem. Let's fix the "a href -> ahref" space problem. Then I'm okay with the translations. Thanks!
The large contribution process changed recently: http://wiki.eclipse.org/Babel_/_Large_Contribution_Import_Process Here is the change: Determine the accuracy of the contribution. 1. Reviewed: Translations were done by professionals, and were reviewed and tested in context by loading them up in Eclipse 2. Fuzzy: Translations were not done by professional translators; translations were done using software and dictionaries; translations were done by professional translators, but were not reviewed and tested in context. 3. If unsure, ask the contributor. If unsure, choose Fuzzy. Could you please state whether those translations were made by professionals, reviewed and tested in context ? I will work on helping importing this contribution as soon as I have your answer on this matter.
Comment 0 states 'This is based on automatic translation by Pleiades translation engine and blancoNLpackGenerator.' My best guess would be '2'
The translation set in our contribution surely had been well reviewed by many Japanese engineers in real Eclipse environment. Therefore, it should be "1".
(In reply to comment #19) Thanks Mori-san. We will go for '1' as you advise.
OK, I gave it a go. I changed the import_translation_zip.php file to filter out \=, \' ' and \: and replace them by =, ' ' and : respectively. I imported the languages pack in the staging area. Can you please review the result ? http://babel.eclipse.org/staging/recent.php I tried this: select * from translations where value LIKE "%ahref%"; it returned an empty set so this sounds like we might be good to go.
New translations look good. +1 to make it live.
Thank you for your effort. We (JWG) also now checking.
We checked it. It looks OK. Thanks a lot.
The translations have been added to the live server: http://babel.eclipse.org/babel/recent.php Thanks for the reviewing and the hard work you pulled into this everybody!
