Bug 237292 - [fiximprove] Configure jar/jad names in create package
Summary: [fiximprove] Configure jar/jad names in create package
Status: CLOSED FIXED
Alias: None
Product: MTJ (Archived)
Classification: Tools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: All Windows XP
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Gustavo de Paula CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, ui, usability
Depends on:
Blocks:
 
Reported: 2008-06-16 11:08 EDT by Gustavo de Paula CLA
Modified: 2008-10-15 09:23 EDT (History)
2 users (show)

See Also:


Attachments
configure the JAR + JAD names on the project properties page (11.41 KB, patch)
2008-06-23 01:16 EDT, Gang(Allen) Ma CLA
no flags Details | Diff
new version of the patch for the bug (17.13 KB, patch)
2008-06-24 22:54 EDT, Gang(Allen) Ma CLA
wds057: iplog+
Details | Diff
the updated doc image(propProject1.png) (28.35 KB, image/png)
2008-06-24 22:56 EDT, Gang(Allen) Ma CLA
wds057: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo de Paula CLA 2008-06-16 11:08:00 EDT
JAR and JAD file names are based on the project name. most carriers have specific requirements about those names. it is important that the developer can easily configure the JAR + JAD names during the build process.

this could be done on the project preferences.
Comment 1 Gang(Allen) Ma CLA 2008-06-23 01:16:29 EDT
Created attachment 105610 [details]
configure the JAR + JAD names on the project properties page
Comment 2 Gustavo de Paula CLA 2008-06-23 15:46:54 EDT
hi gang,

i just reviewed the contribution... the code is really good. thanks.

i have some comments about it:
+ file org.eclipse.mtj.ui\src\org\eclipse\mtj\ui\MTJUIPluginResources.properties
change constant J2MEProjectPropertiesPage.JarFileName to "JAR file name":

+ file  org.eclipse.mtj.ui\src\org\eclipse\mtj\ui\internal\properties\J2MEProjectPropertiesPage.java
- the input page validation seems to be not following eclipse UI guide. The error message is shown in bold and without icon. Is it possible that you change it to be similar to the javadoc properties page? if it is too complex for now, we can commit it as it is and open another CR to fix this later (it is up to you, please let me know what you prefer)
- it would also be nice if we can update the help documentation to describe those new options, but we can also do this is a separated bug. If you prefer to do it now, also please let me know. otherwise, please open a bug and someone can do that later)
Comment 3 Gang(Allen) Ma CLA 2008-06-23 22:17:27 EDT
Hi Gustavo,
1,  no problem, I will change it.
2,  It is easy to change it to be similar to the javadoc properties page, I think we don't need another CR. But I just do it following the MIDlet Suite Signing properties page(the manner of showing error message), need we fix it on the MIDlet Suite Signing properties page?
3,  I can update the help documentation now, but where to put the new options in the documentation? Do you have any suggestions, or open another CR, I'm not sure.
Comment 4 Gustavo de Paula CLA 2008-06-24 12:08:33 EDT
hi,

see comments below

:)
gustavo

(In reply to comment #3)
> Hi Gustavo,
> 1,  no problem, I will change it.
ok

> 2,  It is easy to change it to be similar to the javadoc properties page, I
> think we don't need another CR. But I just do it following the MIDlet Suite
> Signing properties page(the manner of showing error message), need we fix it on
> the MIDlet Suite Signing properties page?

eclipseme was not following all eclipse Ui standards. we opened a bug to validate all dialogs and do the necessary changes in the future. if it is possible can you go on and change both the signing and the JAr/JAD pages to follow the javadoc page?

> 3,  I can update the help documentation now, but where to put the new options
> in the documentation? Do you have any suggestions, or open another CR, I'm not
> sure.
> 

the documentation that describe the preference pages is at page: Mobile Tools for Java -> References -> Project Properties.

this help content is placed on the file /org.eclipse.mtj.docs/docs/refPropProject.html. if you need to update some of the images, they are placed on /org.eclipse.mtj.docs/docs/img
Comment 5 Gang(Allen) Ma CLA 2008-06-24 22:54:58 EDT
Created attachment 105776 [details]
new version of the patch for the bug

In this version of patch, 
1. change constant J2MEProjectPropertiesPage.JarFileName to "JAR file name:"
2. change the input page validation to follow the eclipse UI guide, also I change the signing page for the requirement.
3. update the help documentation, the updated image: propProject1.png is also uploaded.
Comment 6 Gang(Allen) Ma CLA 2008-06-24 22:56:01 EDT
Created attachment 105777 [details]
the updated doc image(propProject1.png)
Comment 7 Gustavo de Paula CLA 2008-07-02 13:49:02 EDT
all changes committed to svn. sorry for the delay. my laptop crashed last week :(

on Friday nightly build, you will be able to download them. 
Comment 8 Gustavo de Paula CLA 2008-10-15 09:23:07 EDT
all bugs we integrated and release on MTj 0.9