Bug 237076 - When applying text edits, don't use CREATE_UNDO | UPDATE_REGIONS if not needed
Summary: When applying text edits, don't use CREATE_UNDO | UPDATE_REGIONS if not needed
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.8   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-06-13 09:48 EDT by Dani Megert CLA
Modified: 2011-10-11 02:51 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-06-13 09:48:59 EDT
3.4 RC4.

We have several places in the code where we apply text edits with CREATE_UNDO | UPDATE_REGIONS flags where this is not needed.
Comment 1 Dani Megert CLA 2008-06-13 09:50:09 EDT
We need to revisit places where e.g. position updates aren't needed and where undo isn't needed because normal text changes are undone.
Comment 2 Dani Megert CLA 2009-04-03 09:34:36 EDT
Too late for this.
Comment 3 Dani Megert CLA 2010-06-21 07:18:17 EDT
To decide during 3.7 M1.
Comment 4 Dani Megert CLA 2011-10-11 02:51:26 EDT
Looked at this. The performance gain for this change is very small to zero and there are tons of places where apply(...) is invoked. We would have to go through each case and investigate which flags are indeed needed. This is too much work for such a small gain.