Bug 236814 - [jsr199] EclipseCompiler#getTask does not respect its contract when its first argument is null
Summary: [jsr199] EclipseCompiler#getTask does not respect its contract when its first...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.6 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-12 05:16 EDT by Maxime Daniel CLA
Modified: 2010-03-09 01:11 EST (History)
4 users (show)

See Also:
Olivier_Thomann: review-

Attachments
Suggested fix + test case (1.81 KB, patch)
2008-06-12 06:45 EDT, Maxime Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2008-06-12 05:16:19 EDT 
I20080609-1311

JavaCompiler#getTask javadoc reads:
     * @param out a Writer for additional output from the compiler;
     * use {@code System.err} if {@code null}
EclipseCompiler#getTask uses System.out instead.

Added inactive CompilerInvocationTest#22.
Comment 1 Maxime Daniel CLA 2008-06-12 06:45:14 EDT 
Created attachment 104649 [details]
Suggested fix + test case
Comment 2 Maxime Daniel CLA 2008-06-12 06:45:48 EDT 
Kent, pls let me know what you think.
Comment 3 Kent Johnson CLA 2008-06-12 10:03:52 EDT 
Isn't the JavaDoc wrong ?

I would think the default setting would be System.out when the param is null.
Comment 4 Jerome Lanneluc CLA 2009-04-28 11:33:24 EDT 
Not for 3.5
Comment 5 Olivier Thomann CLA 2010-02-12 15:31:35 EST 
Released for 3.6M6.
Might be a typo in the javadoc, but the getTask(..) doesn't allow to provide a standtard output and a standard error streams.
Comment 6 Jay Arthanareeswaran CLA 2010-03-09 01:11:11 EST 
Verified for 3.6M6 by code verification.