Bug 236680 - TVT34:TCT775: TVT FR - Apostrophe issue in Generate DDL
Summary: TVT34:TCT775: TVT FR - Apostrophe issue in Generate DDL
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL: 775
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-11 12:57 EDT by CDE Administration CLA
Modified: 2008-07-21 15:17 EDT (History)
5 users (show)

See Also:
neil.hauge: review+

Attachments
3_001180_Apostrophe_GenerateDDL.png (190.94 KB, image/png)
2008-06-11 12:57 EDT, CDE Administration CLA 		no flags Details
proposed patch - HEAD (1.35 KB, patch)
2008-07-18 16:29 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CDE Administration CLA 2008-06-11 12:57:22 EDT 
<response_by> martine marin at 2008.06.10.08.46.49 </response_by>
OS: Linux
Build: 0609
Component: WTP
Testcase: 3.001180
Steps to reproduce:
Right Click on JPATVT created project
Select JPA Tools
Click Generate DDL
(the platform selected to create the project is Generic)

Apostrophe missing in the error message displayed
File is jpt_ui.properties

Sentence is "DDL generation is not supported by the Generic Platform".

Thanks,

Martine

<response_by> Karl Mittmann at 2008.06.11.08.30.33 </response_by>
This article was reassigned from Category:''TVT/Testing,Inbox''.
Comment 1 CDE Administration CLA 2008-06-11 12:57:31 EDT 
Created attachment 104507 [details]
3_001180_Apostrophe_GenerateDDL.png
Comment 2 CDE Administration CLA 2008-06-11 12:57:37 EDT 
<cde:tctdetail>
Testcase: 3.001180
Project: WSW34
Component: Xfer - Web Tools/jst.jsp
Priority: 2
Subject: TVT FR - Apostrophe issue in Generate DDL
Article ID: 775
Originator: mmarin@fr.ibm.com
</cde:tctdetail>
Comment 3 CDE Administration CLA 2008-06-11 13:31:17 EDT 
[Added by CDE: Rejected by the CDE Bridge]
Comment 4 CDE Administration CLA 2008-06-11 13:31:24 EDT 
[Added by CDE: Updated by the CDE Bridge because the corresponding problem has moved out of the bridge domain]
Comment 5 CDE Administration CLA 2008-06-12 11:32:29 EDT 
<response_by> John Ryding at 2008.06.12.10.03.37 </response_by>
This has been deferred. It will be considered for the 3.4.1 service pack.
Comment 6 CDE Administration CLA 2008-06-12 11:32:46 EDT 
<cde:tctdetail>
Testcase: 3.001180
Project: 
Component: Xfer - Web Tools/jst.jsp
Priority: 2
Subject: TVT FR - Apostrophe issue in Generate DDL
Article ID: 775
Originator: mmarin@fr.ibm.com
</cde:tctdetail>
Comment 7 Neil Hauge CLA 2008-07-08 09:56:53 EDT 
This appears to be a translation issue, so guessing this should be an internal bug?
Comment 8 Kit Lo CLA 2008-07-12 12:53:06 EDT 
I think the problem is in org.eclipse.jpa/components/jpa/plugins/org.eclipse.jpt.ui/src/org/eclipse/jpt/ui/internal/platform/generic/GenericPlatformUi.java

protected void displayNotSupportedMessage(String title, String message) {
    String formattedMessage = MessageFormat.format(message, message);
    Shell currentShell = Display.getCurrent().getActiveShell();
    MessageDialog.openInformation(currentShell, title, formattedMessage);
}

Normal practice is to process a string with MessageFormat ONLY IF it contains a subsitution variable like {0}.

GenericPlatformUiDialog_notSupportedMessageText does not contain any subsitution variable. If the string is processed by MessageFormat, MessageFormat will remove the single quote.
Comment 9 Karen Butzke CLA 2008-07-18 16:29:53 EDT 
Created attachment 107864 [details]
proposed patch - HEAD

patch removes the MessageFormat call, this method is not used anywhere else and since there are not arguments it is not necessary to use MessageFormat.
Comment 10 Karen Butzke CLA 2008-07-21 15:17:32 EDT 
checked in to HEAD, no branch for maintenance yet