Bug 236480 - J2EEModelProvider extension point schema invalid
Summary: J2EEModelProvider extension point schema invalid
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Chuck Bridgham CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-10 14:13 EDT by Paul Fullbright CLA
Modified: 2008-06-30 17:11 EDT (History)
1 user (show)

See Also:
cbridgha: pmc_approved+

Attachments
proposed patch (776 bytes, patch)
2008-06-10 14:16 EDT, Paul Fullbright CLA 		no flags Details | Diff
amended patch (1.13 KB, patch)
2008-06-10 16:09 EDT, Paul Fullbright CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Fullbright CLA 2008-06-10 14:13:01 EDT 
The current schema for the extension point won't validate any extension, because there is not a declaration in the root element for the <provider> tag.  All extensions therefore show warnings.  Validation is especially important for those unfamiliar with the extension point.a

<patch to follow>
Comment 1 Paul Fullbright CLA 2008-06-10 14:16:00 EDT 
Created attachment 104360 [details]
proposed patch

The amended schema adds unbounded number of <provider> tags to root <extension> tag.
Comment 2 Paul Fullbright CLA 2008-06-10 16:09:02 EDT 
Created attachment 104379 [details]
amended patch

(Instead of opening another bug, I'm going to extend upon this one.)

The schema also doesn't validate what the requirements are of the factory class, which I believe must simple implement IModelProviderFactory.  I've amended the patch to include this information (and also clean up some previously unnoticed editor artifacts.)
Comment 3 Carl Anderson CLA 2008-06-18 22:04:16 EDT 
Committed to R3_0_maintenance
Comment 4 Chuck Bridgham CLA 2008-06-25 10:57:52 EDT 
Just adding comment that I approved
Comment 5 Carl Anderson CLA 2008-06-30 17:11:17 EDT 
Also committed to HEAD