Bug 236327 - [api][dstore] Add IServerLauncher2#setTimeout() API
Summary: [api][dstore] Add IServerLauncher2#setTimeout() API
Status: NEW
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: Future   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on: 235756
Blocks:
  Show dependency tree
 
Reported: 2008-06-09 18:17 EDT by Martin Oberhuber CLA
Modified: 2008-11-19 01:51 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-06-09 18:17:59 EDT
+++ This bug was initially created as a clone of Bug #235756 +++

From bug 235756: When user has specified a different timeout for connections, both the local client and the server launcher must agree on the timeout value. Therefore IServerLauncher#setTimeout() API is needed.

In order to clean up the way this is currently done, we'll need new API.

In order to remain API Compatible, we'll need IServerLauncher2#setTimeout(), since IServerLauncher is an interface that can be implemented by clients, so extending the interface would break binary compatibility.
Comment 1 David McKnight CLA 2008-11-18 11:21:40 EST
Currently the only IServerLauncher is the REXEC one and it's setSocketTimeoutValue() is set via:

if (starter instanceof RexecDstoreServer){			((RexecDstoreServer)starter).setSocketTimeoutValue(timeout);
}

Since this involves a breaking API change, I'll defer the fix for this.
Comment 2 Martin Oberhuber CLA 2008-11-19 01:51:38 EST
A simpler way for achieving the setTimeout() capability without breaking API may be to define a well-known Property slot for the remote socket timeout. Server Launcher implementations are then expected to read that timeout property from the IServerLauncherProperties / PropertySets. Older implementations who are not yet aware of this Property slot would simply not read it.

It looks like all we need is a public static final String REMOTE_SOCKET_TIMEOUT
to hold the Property key. Does that make sense?