Bug 236252 - Batch compiler's help should not have 'release candidate-4' in the version name
Summary: Batch compiler's help should not have 'release candidate-4' in the version name
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-09 11:10 EDT by Jerome Lanneluc CLA
Modified: 2008-06-10 15:30 EDT (History)
3 users (show)

See Also:
Mike_Wilson: pmc_approved+
jerome_lanneluc: review+
philippe_mulet: review+
frederic_fusier: review+
kent_johnson: review+

Attachments
Proposed fix (1.93 KB, patch)
2008-06-09 12:58 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-06-09 11:10:38 EDT 
I20080606-0100

The batch compiler's help version is "0.872, 3.4.0 release candidate-4". We should change it to "0.872, 3.4.0" so that we don't make users think they're not using the latest.

The JDT/Core build notes should also be updated the same way.
Comment 1 Jerome Lanneluc CLA 2008-06-09 11:11:27 EDT 
Olivier, please make the change once 3.4RC4 is declared.
Comment 2 Olivier Thomann CLA 2008-06-09 11:13:10 EDT 
I think we should change it to:
0.873, 3.4.0

since changing this will force a retagging of the whole project with version v_873.
Comment 3 Jerome Lanneluc CLA 2008-06-09 11:23:04 EDT 
(In reply to comment #2)
> I think we should change it to:
> 0.873, 3.4.0
> 
> since changing this will force a retagging of the whole project with version
> v_873.
> 
Correct. Sorry for the confusion.
Comment 4 Olivier Thomann CLA 2008-06-09 12:58:32 EDT 
Created attachment 104189 [details]
Proposed fix
Comment 5 Frederic Fusier CLA 2008-06-09 13:13:04 EDT 
+1
Comment 6 Kevin McGuire CLA 2008-06-10 15:00:17 EDT 
Doing bug cleanup. Is this still a candidate for 3.4?

McQ, note it has you flagged for PMC approval with four +1 code checks.
Comment 7 Olivier Thomann CLA 2008-06-10 15:06:35 EDT 
Yes, this is definitely a candidate for 3.4. We don't want to show a release candidate version for the 3.4.0 batch compiler version.
I am waiting for PMC approval to release.
Comment 8 Mike Wilson CLA 2008-06-10 15:14:09 EDT 
Let's fix it.
Comment 9 Olivier Thomann CLA 2008-06-10 15:30:46 EDT 
Released for 3.4.