Bug 23585 - Reorder parameter refactoring of constructors broken [refactoring]
Summary: Reorder parameter refactoring of constructors broken [refactoring]
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M2   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 24230
Blocks:
  Show dependency tree
 
Reported: 2002-09-14 09:50 EDT by humphreys CLA
Modified: 2002-10-17 08:45 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description humphreys CLA 2002-09-14 09:50:48 EDT 
The following refactoring does not work: reorder parameters of constructors. 
This works for non-constructor methods but fails for constructors. A simple 
(double, double) will demonstrate the flaw. The constructor itself is changed 
but none of the constructor references are updated.
Comment 1 Adam Kiezun CLA 2002-09-17 04:54:53 EDT 
too late to fix for M1 - i will disable the action for constructors.
will fix after M1.

reducing severity - it's disabled not so nobody will get hurt
Comment 2 Adam Kiezun CLA 2002-09-30 13:32:14 EDT 
blovked by a jcore bug
Comment 3 Adam Kiezun CLA 2002-10-11 14:37:24 EDT 
fixed.
since you can now add and remove params
one missing special case is than no-arg construcotrs can have implicit 
references
class A{
 A(){}
}
class B(){
 B(){} //<<reference to A()
}

adding a parameter to A() must result in
class A{
 A(int i){}
}
class B(){
 B(){
   super(0); //<<newly inserted code
 }
}


before this is implemented i disable this operation on non-arg construcotrs
add yourself to bug 24713 if you wish to be notified when it gets fixed