Community
Participate
Working Groups
Found while working on bug 235626: In org.eclipse.rse.dstore.security plugin, UniversalSecurityProperties, externalized Strings are missing. This had not been discovered before, because all of the Strings had been addressed incorrectly; this is now being fixed with bug 235626. I dreamed up some default messages for the missing PII Keys, but I think that these should really be replaced with the proper messages from existing IBM product(s). The missing keys are in UniversalSecurityProperties.properties: # FIXME MISSING STRINGS START RESID_SECURITY_ALGORITHM_ERROR_ = Algorithm error in Keystore %1 RESID_SECURITY_LOAD_KEYSTORE_ERROR_ = An error occurred when processing Keystore. RESID_SECURITY_KEY_LOAD_ERROR_ = Error loading key from %1 RESID_SECURITY_INITIALIZE_ERROR_ = Error initializing keystore at %1 RESID_SECURITY_SECURITY_PROVIDER_ERROR_ = Missing Security Provider # FIXME MISSING STRINGS END Note again, that the messages here were just dreamed up by me and are likely NOT correct. All messages can only occur in error messages; I did not check, though, under what circumstances the corresponding exceptions are thrown and/or if they even can ever get thrown. Note that before the fix from bug 235626, existing behavior would have replaced the NLS MEssage with its key, so instead of a proper error message users would have read RESID_SECURITY_KEY_LOAD_ERROR without a message substitution. -----------Enter bugs above this line----------- TM 3.0RC2 testing ------------------------------------------------
Dave M -- I'm assigning to you. Please fix these ASAP after the patch containing them is committed. There is one last PII translation and these can make that shipment. I can review. Since this is a properties file there is not much risk in putting these in RC4, but I want them in the nightly build by Thursday evening.
(In reply to comment #1) > Dave M -- > I'm assigning to you. Please fix these ASAP after the patch containing them is > committed. There is one last PII translation and these can make that shipment. > I can review. Since this is a properties file there is not much risk in putting > these in RC4, but I want them in the nightly build by Thursday evening. What exactly needs to be done here? I see that we do have these strings in the HEAD version: # FIXME MISSING STRINGS START RESID_SECURITY_ALGORITHM_ERROR_ = Algorithm error in Keystore %1 RESID_SECURITY_LOAD_KEYSTORE_ERROR_ = An error occurred when processing Keystore. RESID_SECURITY_KEY_LOAD_ERROR_ = Error loading key from %1 RESID_SECURITY_INITIALIZE_ERROR_ = Error initializing keystore at %1 RESID_SECURITY_SECURITY_PROVIDER_ERROR_ = Missing Security Provider # FIXME MISSING STRINGS END
Read the bug please: The Strings were invented by me and I have no idea whatsoever if they are correct. You'll need to check earlier versions of IBM products.
Created attachment 103963 [details] patch to bring back original property values Here is a patch with the original values.
Well, my Strings were not that bad after all :-) That's a trivial fix affecting non-code only, so feel free to commit even without DaveD's review. After committing, please perform Right-click > Source > Find Broken Externalized Strings... just to make sure. It somehow failed in my workspace, perhaps it works ok in yours.
I've committed the change to cvs. Using Find Broken Externalized Strings, I get the following message: Undefined keys in: UniversalSecurityProperties.java - org.eclipse.rse.internal.dstore.security However, the message is on UniversalSecurityProperties with the following line (and that doesn't make much sense): initializeMessages(BUNDLE_NAME, UniversalSecurityProperties.class);
Yes, that's what I've seen too. I tried to review and check a lot of things but couldn't find any real problem.
