Community
Participate
Working Groups
<response_by> Stepan Kvapilik at 2008.06.03.15.14.39 </response_by> Hi, I was asked to separate the TCT#647 to two problems, so here is the 2nd one: OS: Linux Build date: 0602 Component/Function name: any Blocking: NO Tester Name: Ji?? Motjekz?k (Czech) Steps to recreate the problem: In eclipse, go to the file/new/other menu. Problem: I found one more string which should be externalized in this menu. - The menu item "XML" and its subitem "XML" are taken from the same string "_UI_WIZARD_NEW_XML". As the meaning of the menu item is "group for XML files", while the inner item means "concrete XML file type", the translation of these two strings should be separated. The problem was checked in the EN build with string IDs. Attaching screenshot for reference. Jiri <response_by> Karl Mittmann at 2008.06.03.15.55.09 </response_by> This article was reassigned from Category:''TVT/Testing,Inbox''.
Created attachment 103441 [details] file-new.png
<cde:tctdetail> Testcase: N/A Project: WSW34 Component: Xfer - Web Tools/wst.xml Priority: 2 Subject: two more strings to externalize in file/new menu II Article ID: 723 Originator: ibm@hiero.cz </cde:tctdetail>
Created attachment 103656 [details] patch The Wizard Category "XML" is now a separate string from the new file "XML".
review and tested fix. it looks good.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is an important bug to fix because we want to fix externalized strings to be a good citizen for all countries. Not fixing this will be confusing if translators want to distinguish the difference between an XML category versus an XML file. * Is there a work-around? If so, why do you believe the work-around is insufficient? No * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Fix has been manually tested by me and Nick Sandonato * Give a brief technical overview. Who has reviewed this fix? Both the label for the XML category and the label for the New XML wizard in the New files dialog were using the same string. Fix is to create a new string for the XML category label. Nick and I have reviewed the fix. * What is the risk associated with this fix? None.
I'm fine with this, but would also ask you remove the extraneous <keywordReference id="preferenceKeywords.severities"/>
Approved.
Created attachment 103689 [details] org.eclipse.wst.xml.ui.patch (In reply to comment #6) > I'm fine with this, but would also ask you remove the extraneous > <keywordReference id="preferenceKeywords.severities"/> Actually, it's not extraneous. There are additional preference keywords. That line should be changed to: <keywordReference id="org.eclipse.wst.xml.ui.severities"/> And then the keyword id should be defined like so: <keyword label="%preferenceKeywords.severities" id="org.eclipse.wst.xml.ui.severities"/> This way, if you filter preferences pages on severity keywords like "error" "ignore" "warning" you will get the XML Files preference page. This additional fix is low risk. The preference keywords are already defined/externalized in plugin.properties. The keyword id just needed to be defined.
Fix committed and released. Tagged v200806051910.
Verified in S-3.0RC4-20080610084135.
<response_by> Stepan Kvapilik at 2008.06.12.10.52.13 </response_by> Thank you for externalizing, closing TCT. Jiri
<cde:tctdetail> Testcase: N/A Project: Component: Xfer - Web Tools/wst.xml Priority: 2 Subject: two more strings to externalize in file/new menu II Article ID: 723 Originator: ibm@hiero.cz </cde:tctdetail>
