Bug 235212 - [ui] RepositoryManipulationDialog should update repos in the background
Summary: [ui] RepositoryManipulationDialog should update repos in the background
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-06-02 15:42 EDT by Susan McCourt CLA
Modified: 2009-06-09 16:24 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2008-06-02 15:42:08 EDT 
The manage sites dialog updates the enabled state for repos when the OK button is pressed.  This is done from the UI thread.  

If there are a large number of sites being enabled or disabled, this seemingly hangs the UI thread.  Perhaps its having to load repositories to change the Enabled state.  Need to investigate where the time is being spent here.
Comment 1 John Arthorne CLA 2008-06-02 17:25:33 EDT 
Strange, from looking at the repo manager code, setting enablement shouldn't take much time. It causes the preference file to be updated, so there is some minimal local file system I/O.
Comment 2 Susan McCourt CLA 2008-06-02 17:46:13 EDT 
It's possible that I was experiencing GC or some other random hang.  It doesn't happen all the time.  Leaving this bug open so I can investigate (post 3.4) the code path here and see if there's anyone who might be loading a repo in the UI thread as a side effect.
Comment 3 Susan McCourt CLA 2009-06-09 16:24:09 EDT 
I have not seen this problem in the 3.5 stream.  Marking "worksforme"