Bug 235204 - Advice markers not placed properly on recursive calls
Summary: Advice markers not placed properly on recursive calls
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: 1.5.3   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.5.3   Edit
Assignee: AJDT-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-02 15:02 EDT by Andrew Eisenberg CLA
Modified: 2009-05-15 00:15 EDT (History)
1 user (show)

See Also:


Attachments
Failing test case for markers (5.85 KB, patch)
2008-06-02 18:25 EDT, Andrew Eisenberg CLA
andrew.eisenberg: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2008-06-02 15:02:45 EDT
Advice marker for a call pointcut is not being properly placed.  The following aspect and class illustrate this:

package recursivepackage;

public aspect RecursiveCatcher {

       pointcut recur() : 
    	   call(public void 
    			   *.recursiveCall(int));


       before(): recur() {
    	   // empty
       }

       
   	public void recursiveCall(int i) {  // marker is here
				recursiveCall(i);  // marker should be here
	}

}

Here, AJDT places an advice marker at the execution site (ie, on the line "public void recursiveCall(int i) {").  It should be placed at the line "recursiveCall(i)".
Comment 1 Andrew Eisenberg CLA 2008-06-02 18:25:58 EDT
Created attachment 103224 [details]
Failing test case for markers

Attaching a failing test case that includes the above aspect slightly altered.  

This is an aspectj bug.  Fix in that is forthcoming.
Comment 2 Andrew Clement CLA 2008-06-03 11:21:21 EDT
AspectJ fix is in, i'll put it into AJDT later today.
Comment 3 Andrew Clement CLA 2008-06-06 17:13:52 EDT
patch committed.
iplog