Bug 235148 - RSENewConnectionWizardRegistry contains a cache that is dead code
Summary: RSENewConnectionWizardRegistry contains a cache that is dead code
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-02 10:44 EDT by Martin Oberhuber CLA
Modified: 2008-06-03 04:51 EDT (History)
1 user (show)

See Also:
uwe.st: review+

Attachments
Patch getting rid of dead code (5.94 KB, patch)
2008-06-02 14:00 EDT, Martin Oberhuber CLA 		no flags Details | Diff
Updated patch getting rid of one more if() (8.02 KB, patch)
2008-06-03 04:51 EDT, Martin Oberhuber CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-06-02 10:44:25 EDT 
private HashMap RSENewConnectionWizardRegistry#cache is only ever read, and never written. I suggest removing this dead code.

-----------Enter bugs above this line-----------
TM 3.0RC2 testing
installation : eclipse-SDK-3.4RC3 (I20080530-1730), cdt-5.0RC2 (200805231539), 
     DSF-1.0rc2 (20080527), emf-2.4.0rc2, Findbugs-1.3.3, Releng.Tools-3.4RC3, 
     RSE-3.0RC2, RXTX-2.1-7r3b, Subversive-0.7.0.v20080517, FTP_WebDav-3.2.2
     org.tigris.MemMonitor, WR-Retriever-3.0.v20070604,
RSE install  : RSE 3.0RC2 in workspace, TM-terminal, TM-discovery
java.runtime : Sun 1.6.0_05-b13 -Xmx512m -XX:MaxPermSize=128m
os.name:     : Windows XP 5.1, Service Pack 2
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2008-06-02 14:00:08 EDT 
Created attachment 103164 [details]
Patch getting rid of dead code

Attached patch gets rid of the dead code.
Comment 2 Martin Oberhuber CLA 2008-06-02 14:01:18 EDT 
Uwe can you please review the patch -- it's trivial but my workspace currently contains other stuff too so please check that this doesn't break anything.
Comment 3 Uwe Stieber CLA 2008-06-03 04:48:43 EDT 
Patch is fine.
Comment 4 Martin Oberhuber CLA 2008-06-03 04:51:14 EDT 
Created attachment 103262 [details]
Updated patch getting rid of one more if()

As discussed personally with Uwe, here is an updated patch getting rid of one more unnecessary if()
Comment 5 Martin Oberhuber CLA 2008-06-03 04:51:50 EDT 
Patch committed:
[235148] get rid of dead code for caching