Bug 235137 - ScriptSearchPage resets the last chosen "Limit To" option
Summary: ScriptSearchPage resets the last chosen "Limit To" option
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 0.95   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alon Peled CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-06-02 10:05 EDT by Alon Peled CLA
Modified: 2010-06-11 06:58 EDT (History)
3 users (show)

See Also:


Attachments
comments out the code that resets "Limit To" (1.21 KB, patch)
2008-06-02 10:06 EDT, Alon Peled CLA
alex.panchenko: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Peled CLA 2008-06-02 10:05:42 EDT
After a search is performed and the dialog is opened a second time - the "Limit To" value is always set to references and not to the last chosen value. Other values are restored as they should.
I attached a patch to show where I think it should be fixed.
Comment 1 Alon Peled CLA 2008-06-02 10:06:52 EDT
Created attachment 103116 [details]
comments out the code that resets "Limit To"
Comment 2 Andrey Platov CLA 2008-06-03 02:21:51 EDT
Hi Alon,

Looks good and we're going to have this in 0.95RC3, please can you put a
message on the bugzilla for our IP Records?

Legal Message: I, {name}, declare that I developed attached code from scratch,
without referencing any 3rd party materials except material licensed under the
EPL. {I am authorized by my employer to make this contribution under the EPL.} 

Thank you!
Comment 3 Alon Peled CLA 2008-06-03 03:00:26 EDT
Hi Andrey,

I am not familiar with this requirement for the IP process. Where did you get this legal message?

Moreover, in this bug i only made a slight modification in your code. There is no code of mine there.
Comment 4 Andrey Platov CLA 2008-06-03 03:11:41 EDT
Hi Alon, 

That's from http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf

and Project IP Log: http://www.eclipse.org/projects/dev_process/project-log.php

The Eclipse IP Policy requires certain due diligence and record keeping. Small contributions in the form of Bugzilla patches and the like can be committed directly to the code base (after the appropriate contributor information is recorded). Medium, large, and all third-party (non-EPL licensed) contributions require the Code Contribution Questionnaire and additional record keeping. Maintaining a current and accurate Project Log is the best way to keep this information up-to-date. 

DSDP TM project has good information on applying patches according to Eclipse Development Process: http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib

Kind Regards,
Andrey
Comment 5 Andrei Sobolev CLA 2008-06-04 02:49:48 EDT
Applied. Thanks.