Bug 234493 - [ImageSupport] Embedded images on the diagram are incorrectly painted on the image
Summary: [ImageSupport] Embedded images on the diagram are incorrectly painted on the ...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.1   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-28 16:39 EDT by Alex Boyko CLA
Modified: 2008-08-13 13:10 EDT (History)
2 users (show)

See Also:
Ed.Merks: pmc_approved+
ahunter.eclipse: review+

Attachments
proposed patch (1.22 KB, patch)
2008-05-29 11:36 EDT, Alex Boyko CLA 		aboyko: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2008-05-28 16:39:23 EDT 
Suppose you have a diagram with a couple of figures that have image files embedded (i.e. use ScalableImageFigure to display the image).
Zomm = 100% export the diagram to PNG or JPEG - everything is diplayed fine
Zoom = 400% export the diagram to PNG or JPEG.
Open the image file in the image viewer:
You'll see that embedded images are clipped because their bounds on the image actually correct - the original size, zoom factor is ignored, however the image itself is still zoomed.
Comment 1 Alex Boyko CLA 2008-05-28 17:28:20 EDT 
So on the image you see embedded images as 400% zoomed in images clippes by their original size bounds.
Comment 2 Alex Boyko CLA 2008-05-29 11:36:04 EDT 
Created attachment 102664 [details]
proposed patch

This the patch to review that fixes the issue.
Comment 3 Alex Boyko CLA 2008-05-29 11:42:43 EDT 
Hi Ed, we'd like to get PMC approval for this fix to go in. Could you please take a look at the patch and, hopefully, approve it? (A typo is being fixed here)
Hi Anthony, I attached the fix (patch) i'm proposing to commit to fix this issue. Could you approve it please?
Comment 4 Alex Boyko CLA 2008-05-29 16:14:23 EDT 
Committed to head.
Comment 5 Richard Gronback CLA 2008-08-13 13:10:05 EDT 
[target cleanup] 2.1 RC was the original target milestone for this bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug