Bug 234414 - NPE when creating plugin from 'Host plug-in:' link
Summary: NPE when creating plugin from 'Host plug-in:' link
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC3   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-05-28 12:16 EDT by Martin Aeschlimann CLA
Modified: 2008-05-28 17:12 EDT (History)
3 users (show)

See Also:
curtis.windatt.public: review+
darin.eclipse: review+


Attachments
org.eclipse.pde.ui.patch (2.88 KB, patch)
2008-05-28 16:24 EDT, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (836 bytes, application/octet-stream)
2008-05-28 16:24 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-05-28 12:16:42 EDT
3.4

- Extract attachment 102417 [details], and import it as existing project
  It's a fragment of a plug-in that doesn't exist yet

- Open the manifest editor, go to the 'Overview' page and click on the link 'Host plug-in:'.

- In the wizard that opens, enter the name 'com.metatomix.semantic.sdbstore' (Note that it would be good if the name was initialized automatically)

- Click next, and 'Finish' without making any changes

!ENTRY org.eclipse.ui 4 0 2008-05-28 18:08:51.234
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
	at org.eclipse.pde.internal.ui.wizards.plugin.NewPluginProjectWizard.performFinish(NewPluginProjectWizard.java:118)
	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:742)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:373)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:227)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1002)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3801)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3400)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.pde.internal.ui.editor.plugin.FragmentGeneralInfoSection$1.createFragmentPlugin(FragmentGeneralInfoSection.java:105)
	at org.eclipse.pde.internal.ui.editor.plugin.FragmentGeneralInfoSection$1.linkActivated(FragmentGeneralInfoSection.java:91)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleActivate(AbstractHyperlink.java:228)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleMouseUp(AbstractHyperlink.java:316)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.access$2(AbstractHyperlink.java:300)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink$4.handleEvent(AbstractHyperlink.java:119)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1002)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3801)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3400)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2387)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2351)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2203)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:112)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:379)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1212)
Comment 1 Chris Aniszczyk CLA 2008-05-28 16:02:39 EDT
hrmm, I get this exception when importing the existing projects...

Daemon Thread [ModalContext] (Suspended (exception NullPointerException))	
	WizardProjectsImportPage.createExistingProject(WizardProjectsImportPage$ProjectRecord, IProgressMonitor) line: 1217	
	WizardProjectsImportPage.access$16(WizardProjectsImportPage, WizardProjectsImportPage$ProjectRecord, IProgressMonitor) line: 1207	
	WizardProjectsImportPage$17.execute(IProgressMonitor) line: 1161	
	WorkspaceModifyOperation$1.run(IProgressMonitor) line: 104	
	Workspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor) line: 1800	
	WizardProjectsImportPage$17(WorkspaceModifyOperation).run(IProgressMonitor) line: 116	
	ModalContext$ModalContextThread.run() line: 121	
Comment 2 Chris Aniszczyk CLA 2008-05-28 16:14:09 EDT
Well, I debugged it further and figured out getWorkbench() is returning null...
Comment 3 Chris Aniszczyk CLA 2008-05-28 16:24:41 EDT
Created attachment 102511 [details]
org.eclipse.pde.ui.patch

Two problems...

1) we don't properly init the new plug-in project wizards on fragments
2) we shouldn't add working sets to the workbench if none are selected
Comment 4 Chris Aniszczyk CLA 2008-05-28 16:24:44 EDT
Created attachment 102512 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2008-05-28 16:25:16 EDT
Curtis, please review.
Comment 6 Chris Aniszczyk CLA 2008-05-28 16:25:38 EDT
Darin, please review.
Comment 7 Chris Aniszczyk CLA 2008-05-28 16:25:54 EDT
+1 from me.
Comment 8 Curtis Windatt CLA 2008-05-28 16:40:19 EDT
+1
Comment 9 Darin Wright CLA 2008-05-28 17:09:38 EDT
+1
Comment 10 Chris Aniszczyk CLA 2008-05-28 17:12:36 EDT
done.

> 20080528