Comment 1 Gustavo de Paula 2008-05-27 08:51:39 EDT

Created attachment 102140 [details]
Proguard preverifier

Comment 2 Gustavo de Paula 2008-05-27 08:52:54 EDT

In order to use the patch it is necessary to configure proguard in the obfuscation  preferences (at least version 4.0)

Comment 3 Dan Murphy 2008-10-06 03:37:28 EDT

Hi,
Have been using this patch with great success (once tweaked a little). What plans are there to include this in the trunk ?

Comment 4 Gustavo de Paula 2008-10-07 08:34:28 EDT

i just sent yesterday a first draft of 0.9.1 plan. we might add this feature to next release

:)
gustavo

we probably will

(In reply to comment #3)
> Hi,
> Have been using this patch with great success (once tweaked a little). What
> plans are there to include this in the trunk ?
> 

Comment 5 David Aragão 2009-04-30 09:26:58 EDT

Created attachment 133924 [details]
Add proguard preverifier

This patch contains the Add proguard preverifier functionalities(by Gustavo)
I made the refactoring for the actual code and some routines related to the UI

Comment 6 David Aragão 2009-05-12 10:44:14 EDT

Created attachment 135358 [details]
Add proguard preverifier

Updating old patch.

Comment 7 Gustavo de Paula 2009-05-12 15:49:10 EDT

just to double check. is this ready to be reviewed ?

Comment 8 David Aragão 2009-05-13 13:18:48 EDT

Yes, it's ready to review.

(In reply to comment #7)
> just to double check. is this ready to be reviewed ?
> 

Comment 9 David Aragão 2009-05-13 13:40:38 EDT

Created attachment 135639 [details]
Add proguard preverifier

A console test line was removed.
Now it's ready for review.

Comment 10 Gustavo de Paula 2009-05-14 14:28:41 EDT

i just reviewed the patch. i note that you added some public classes. please move them to be internal. we don't want to add any new public class right now

:)
gep

Comment 11 Gustavo de Paula 2009-05-18 12:37:39 EDT

since there is no time to close this today move to a future release.

Comment 12 David Aragão 2009-07-13 14:39:51 EDT

Created attachment 141448 [details]
Add proguard preverifier

Updating Patch

Comment 13 Gustavo de Paula 2009-07-15 10:13:49 EDT

Comment on attachment 141448 [details]
Add proguard preverifier

there are a couple of issues on the patch:
- the class proguardpreverifier should be moved to an internal package
- a new preverifier type need to be added to IPreverifier
- MTJCore.createPreverifier need to be changted in order to create the proguardpreverifier
- this interface is already internal IMTJCoreConstants. use the internal one and remove this public interface
- MidletSuiteProject should not be changed
- there a lot of compilantion errors on this classe PreverificationPreferencePage

Comment 14 David Aragão 2009-07-27 17:05:58 EDT

Created attachment 142704 [details]
Add proguard preverifier

Ready for review

Comment 15 Gustavo de Paula 2009-07-31 11:19:09 EDT

Comment on attachment 142704 [details]
Add proguard preverifier

patch reviewed and approved

Comment 16 Gustavo de Paula 2009-07-31 11:20:50 EDT

code committed to svn. it will be available on next nightly build

Comment 17 Diego Madruga Sandin 2009-10-28 08:45:51 EDT

Released