Bug 234120 - PublicScanner not in sync with internal Scanner
Summary: PublicScanner not in sync with internal Scanner
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC3   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-27 06:44 EDT by Jerome Lanneluc CLA
Modified: 2008-05-30 10:58 EDT (History)
3 users (show)

See Also:
philippe_mulet: review+
frederic_fusier: review+
david_audel: review+

Attachments
Proposed fix (3.86 KB, patch)
2008-05-27 06:47 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2008-05-27 06:44:19 EDT 
I20080523-0100

The class PublicScanner should always be a copy of the internal Scanner. However the fix for bug 102780 did not bring the change to PublicScanner.
Comment 1 Jerome Lanneluc CLA 2008-05-27 06:47:07 EDT 
Created attachment 102127 [details]
Proposed fix
Comment 2 Jerome Lanneluc CLA 2008-05-27 06:48:14 EDT 
Philippe, Frederic, David, please approve/review for RC3
Comment 3 David Audel CLA 2008-05-27 07:24:41 EDT 
Patch looks good: +1
Comment 4 Frederic Fusier CLA 2008-05-27 09:23:20 EDT 
Sorry, I remember to have put this task in my stack but unfortunately, completely forgot to pop it...

This change in Scanner was necessary while scanning text inside comments for the new comments formatter...

Of course, patch looks good, so +1 for RC3
Comment 5 Philipe Mulet CLA 2008-05-27 10:16:15 EDT 
+1 for RC3
Comment 6 Jerome Lanneluc CLA 2008-05-27 11:40:32 EDT 
Fix released for 3.4RC3
Comment 7 David Audel CLA 2008-05-30 10:58:19 EDT 
Verified for 3.4RC4 using build I20080530-0100