Bug 233989 - wsant.bat has trouble with spaces in paths
Summary: wsant.bat has trouble with spaces in paths
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Andrew Mak CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: PMC_approved
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-05-26 13:27 EDT by Andrew Mak CLA
Modified: 2008-06-04 10:41 EDT (History)
3 users (show)

See Also:
kathy: pmc_approved? (david_williams)
kathy: pmc_approved? (raghunathan.srinivasan)
kathy: pmc_approved? (naci.dai)
deboer: pmc_approved+
neil.hauge: pmc_approved+
kathy: pmc_approved? (kaloyan)

Attachments
patch (1.97 KB, patch)
2008-05-26 13:37 EDT, Andrew Mak CLA 		no flags Details | Diff
Add a comment, workspace path should not have trailing path separator (2.01 KB, patch)
2008-05-26 17:45 EDT, Andrew Mak CLA 		makandre: review?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Mak CLA 2008-05-26 13:27:35 EDT 
On windows, it is common to have spaces in paths.  The wsant.bat script has a problem when eclipse is unzipped to a directory with space because the INSTALL_DIRECTORY variable is used to form the LAUNCHER_JAR variable.  If the path is quoted, LAUNCHER_JAR would end up with some extra quotes.  On the other hand, if the path is unquoted, the command fails because -install parameter is broken up with space(s).
Comment 1 Andrew Mak CLA 2008-05-26 13:37:36 EDT 
Created attachment 102012 [details]
patch
Comment 2 Andrew Mak CLA 2008-05-26 17:45:35 EDT 
Created attachment 102061 [details]
Add a comment, workspace path should not have trailing path separator
Comment 3 Andrew Mak CLA 2008-05-27 09:44:09 EDT 
Problem:

If eclipse is unzipped to a path with spaces in the name, wsant.bat script is not able to handle it without some modifications.  It is not too clear in the comments what needs to change and users can shoot themselves in the foot easily.

Fix:

Just adding some comments to the script and make sure parameters are quoted properly.  There is no change to the core logic so it is very low risk.

Review:
Kathy, please review.
Comment 4 Kathy Chan CLA 2008-05-27 12:10:01 EDT 
Patch looks good.  Thanks Andrew!

PMC, please approve for WTP 3.0 RC3.  This problem had been reported by some users and when the problem happens, the user is often confused about what to do to recover.  This fix improves on the usability of the Ant command line tools for Web services.
Comment 5 Tim deBoer CLA 2008-05-27 12:32:24 EDT 
Approved.
Comment 6 Kathy Chan CLA 2008-05-28 11:37:33 EDT 
Patch committed and released to HEAD as v200805281530.
Comment 7 Andrew Mak CLA 2008-06-04 10:41:59 EDT 
Verified on wtp-S-3.0RC3-20080529235434