Bug 233562 - Two copies of PluginSearchOperation
Summary: Two copies of PluginSearchOperation
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-05-22 15:59 EDT by Chris Aniszczyk CLA
Modified: 2009-01-09 15:56 EST (History)
1 user (show)

See Also:

Attachments
patch (12.72 KB, patch)
2009-01-08 16:47 EST, Benjamin Cabé CLA 		caniszczyk: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-05-22 15:59:04 EDT 
org.eclipse.pde.internal.ui.search.PluginSearchOperation
org.eclipse.pde.internal.core.search.PluginSearchOperation

I don't know why but this makes me sad.
Comment 1 Benjamin Cabé CLA 2009-01-08 16:47:57 EST 
Created attachment 122019 [details]
patch

Here is a proposed refactoring.
core & ui version were very similar, the only difference being that the core version was using an "enhanced" ISearchResultCollector (IPluginSearchResultCollector) that imo has no added-value at the moment, so I just removed it...
ISearchResultCollector and PluginSearchOperation are now in org.eclipse.pde.internal.core.search, and references to these two classes have been updated (import update in PluginSearchQuery)
Comment 2 Chris Aniszczyk CLA 2009-01-08 16:49:53 EST 
Thanks Benjamin!

I'm going to review this later!
Comment 3 Chris Aniszczyk CLA 2009-01-09 15:55:51 EST 
Thanks Benjamin!

> 20090109