Bug 233473 - Scan for unsupported tags creates duplicate problems
Summary: Scan for unsupported tags creates duplicate problems
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 232404
  Show dependency tree
 
Reported: 2008-05-22 11:41 EDT by Darin Wright CLA
Modified: 2008-05-22 15:19 EDT (History)
2 users (show)

See Also:
darin.eclipse: review+
Olivier_Thomann: review+

Attachments
patch (6.12 KB, patch)
2008-05-22 14:28 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2008-05-22 11:41:47 EDT 
We are scanning source files more than once for unsupported javadoc tags. Since we traverse the class file container and process assoicated source, we are scanning source once for each top level type, and then once for each inner type. This results in duplicate problems, and we are doing more work than needed.
Comment 1 Michael Rennie CLA 2008-05-22 14:28:50 EDT 
Created attachment 101587 [details]
patch

fixes the multiple error problem: no longer uses the class file containers, only scan the source (or source context) from the backing project.
Comment 2 Olivier Thomann CLA 2008-05-22 14:33:13 EDT 
looks ok to me.
+1.
Comment 3 Darin Wright CLA 2008-05-22 15:18:17 EDT 
+1 - released.
Comment 4 Darin Wright CLA 2008-05-22 15:19:04 EDT 
Fixed.
Comment 5 Darin Wright CLA 2008-05-22 15:19:13 EDT 
Verified.