Bug 233154 - [Axis2] UI rendring problems in eclipse preferences pages with the lables acting as text fields in order to facilitate automation of text translation
Summary: [Axis2] UI rendring problems in eclipse preferences pages with the lables act...
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Lahiru Sandakith CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-05-21 03:19 EDT by Lahiru Sandakith CLA
Modified: 2008-10-29 16:19 EDT (History)
2 users (show)

See Also:


Attachments
2) axis2_prefereces_2.png (80.52 KB, image/png)
2008-05-21 03:21 EDT, Lahiru Sandakith CLA
no flags Details
3) web_services_preferences.png (46.92 KB, image/png)
2008-05-21 03:21 EDT, Lahiru Sandakith CLA
no flags Details
fix for bug 233154 (2.50 KB, patch)
2008-05-21 03:58 EDT, Saminda Wijeratne CLA
no flags Details | Diff
patch for bug 233154 (3.11 KB, patch)
2008-05-21 22:45 EDT, Saminda Wijeratne CLA
no flags Details | Diff
fix to address both windows and linux (2.06 KB, patch)
2008-06-11 05:48 EDT, Saminda Wijeratne CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lahiru Sandakith CLA 2008-05-21 03:19:31 EDT
This issue arises in Linux GTK only. Its starts with making the labels as text in order to facilitate the automation of the translation of the field data to another languages.

The issue is these text would not render in the background color. 
See the attachments.

1) axis2_preferences_1.png
2) axis2_preferences_2.png
3) web_services_preferences.png

This issue exists in preference pages other than axis2 preference pages.
3) is an example for this.
Comment 1 Lahiru Sandakith CLA 2008-05-21 03:21:13 EDT
Created attachment 101194 [details]
2) axis2_prefereces_2.png
Comment 2 Lahiru Sandakith CLA 2008-05-21 03:21:39 EDT
Created attachment 101195 [details]
3) web_services_preferences.png
Comment 3 Saminda Wijeratne CLA 2008-05-21 03:58:07 EDT
Created attachment 101196 [details]
fix for bug 233154

i thought of a simple solution where u can just set the background of these Text boxes to the background color of the preference page. only thing is that you have to do this to each and every label like text boxes. I'm attaching a patch herewith doing that for axis2 preference page.
Comment 4 Lahiru Sandakith CLA 2008-05-21 04:05:49 EDT
Great Saminda, This is a clean alternative solution to the problem. I had a look at the parch and this is a very safe patch that involves changes only to the 

RCS file: /cvsroot/webtools/webservices/plugins/org.eclipse.jst.ws.axis2.ui/src/org/eclipse/jst/ws/internal/axis2/consumption/ui/preferences/Axis2RuntimePreferencePage.java 


+1 for applying the patch.

kathy, is this solution proposed by saminda can be adhered to all the other places in the eclipse preferences ? if so we will be able to supply a one.

Thanks 

Lahiru Sandakith
Comment 5 Lahiru Sandakith CLA 2008-05-21 07:07:41 EDT
Hi Saminda, 

In your fix, the header file is not updated. Please update it and resubmit it (invalidate the older one).

As an example look at this patch on how to update the header. https://bugs.eclipse.org/bugs/attachment.cgi?id=101220

Thanks 
Lahiru Sandakith
Comment 6 Saminda Wijeratne CLA 2008-05-21 22:45:30 EDT
Created attachment 101419 [details]
patch for bug 233154

sorry couldn't update the header on the earlier patch.
Comment 7 Kathy Chan CLA 2008-06-03 10:45:05 EDT
Patch looks OK.  Lahiru, you can commit to WTP 3.0.1.
Comment 8 Lahiru Sandakith CLA 2008-06-08 23:58:29 EDT
I have reviewed the patch and committed it to the 3_0_maintenance branch.

Please verify and close.

Thanks 
Lahiru Sandakith
Comment 9 Saminda Wijeratne CLA 2008-06-11 05:48:22 EDT
Created attachment 104440 [details]
fix to address both windows and linux

Unfortunately the last patch causes problems for windows. I came across this accidently when trying to reproduce a bug in windows. cannot explain exactly why it doesn't work. but the backcolor of the preference page is taken rather than the color of the tab.
This patch will try to address this problem. it will change the color of the tab to the color of the axis2 preference page. WDYT?

Saminda
Comment 10 Lahiru Sandakith CLA 2008-06-11 05:50:49 EDT
reopening as saminda came up with some issues on windows also 
Comment 11 Kathy Chan CLA 2008-06-11 11:10:21 EDT
Lahiru, once you or Saminda have tested this patch on Window and Linux, you can commit it to R3_0_maintenance.
Comment 12 Lahiru Sandakith CLA 2008-06-12 00:25:56 EDT
We both test this and I have already committed this to the R3_0_maintenance. I have verified it and I am making this as resolution fixed.
Comment 13 Kathy Chan CLA 2008-10-27 14:18:25 EDT
This defect has been in resolve state for a while.  Please verify this with the appropriate WTP driver which can be found in:

http://download.eclipse.org/webtools/downloads/

We would verify and close the defect on the originator's behalf if it has not been verified 2 weeks after it's been changed to Verified state.
Comment 14 Kathy Chan CLA 2008-10-29 16:19:02 EDT
Verified.