Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #231827 +++ From bug 231827 comment 9: One minor gotcha I found is that in case no connection at all is available in RSE yet (i.e. "Local" is not installed and RSE is started the first time), the connection dropdown can be empty with nothing selected. The Properties button should be disabled in this case. This can also happen if none of the available connections fits the needs of remotecdt (shell subsystem available). From bug 231827 comment 10: Another Gotcha is that when choosing Properties for Local, the dialog is shown but no values are editable. The button should better be disabled in this case.
Created attachment 101976 [details] proposed patch
Hm... patch seems to address issue (1), but for the case of the "Local" connection selected, it still brings up a Properties dialog where nothing can be edited (and now, not even OK can be pressed). Wouldn't it make more sense to disable the "Properties" button in case a "Local" connection is selected? Also, please add your legal statement as per http://www.eclipse.org/dsdp/tm/development/committer_howto.php#external_contrib Thanks!
Created attachment 101978 [details] reworked patch I've mis-interpreted the statement "The button should better be disabled in this case" :-) Fixed as suggested. And here's the legal statement: I, Johann Draschwandtner, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
That was fast, thanks! Patch applied: 15 added / 2 removed lines. Next time, please also change the Copyright Header in the file, adding a line for your contribution (I did it this time).
