Bug 232803 - Reconcile doesn't find methods with a $ in parameter types
Summary: Reconcile doesn't find methods with a $ in parameter types
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 145598
  Show dependency tree
 
Reported: 2008-05-19 10:32 EDT by David Audel CLA
Modified: 2008-05-23 06:28 EDT (History)
1 user (show)

See Also:
david_audel: review+
frederic_fusier: review+

Attachments
.log from 3.3.2 (16.09 KB, application/octet-stream)
2008-05-19 10:36 EDT, David Audel CLA 		no flags Details
Proposed fix and regression test (6.15 KB, patch)
2008-05-20 05:23 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2008-05-19 10:32:19 EDT 
build I20080516-1333

1) create Cl$ss.java
public interface Cl$ss {
	public void test(Cl$ss c);
	public void foo();
}
2) create Main.java
public class Main {
        void m(Cl$ss c2) {
        	c2.test(c2);
        	c2.foo();
        }
}
There is no problem in the Problem View but there is one in the java editor:
The method test(ss) from the type Cl$ss refer to the missing type ss
Comment 1 David Audel CLA 2008-05-19 10:32:35 EDT 
In 3.3.2 the problem does not appear in the editor but this test case cause a lot of NPE in .log file.
Comment 2 David Audel CLA 2008-05-19 10:36:46 EDT 
Created attachment 100915 [details]
.log from 3.3.2
Comment 3 Jerome Lanneluc CLA 2008-05-20 05:23:59 EDT 
Created attachment 101018 [details]
Proposed fix and regression test
Comment 4 Jerome Lanneluc CLA 2008-05-20 05:39:07 EDT 
From the user's point of view, this is a regression comparing to 3.3.2. The fix is quite simple and I think this should be fixed for 3.4.

David, Frederic, can you please review?
Comment 5 David Audel CLA 2008-05-20 06:19:22 EDT 
Patch looks good, +1.
Comment 6 Frederic Fusier CLA 2008-05-20 07:49:03 EDT 
Patch looks good: +1
Comment 7 Jerome Lanneluc CLA 2008-05-20 09:22:42 EDT 
Fix and test released for 3.4RC2
Comment 8 Eric Jodet CLA 2008-05-23 06:28:59 EDT 
verified for 3.4RC2 using build I20080523-0100