Bug 23272 - Plugin dependence problem
Summary: Plugin dependence problem
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.1 M2   Edit
Assignee: Philipe Mulet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-06 10:49 EDT by Luc Bourlier CLA
Modified: 2002-10-17 10:16 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luc Bourlier CLA 2002-09-06 10:49:31 EDT 
It looks like org.eclipse.jdt.core need org.eclipse.team.core, but the team core
plugin is not a direct or indirect requiered plugin for jdt core.

1. Launch eclipse with an empty workspace.
2. import org.eclipse.jdt.ui and its requiered plugins (with the import plugin
wizard).
org.eclipse.team.core is not imported.
3. Do 'run as/run-time workbench'
4. When the workbench is launched, the .log file contains :
!SESSION Sep 06, 2002 09:52:20.195 ---------------------------------------------
java.version=1.4.1-beta
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=linux, ARCH=x86, WS=gtk, NL=en_US
Command-line arguments: -dev bin -data
/home/lbourlie/host-gtk/eclipse/runtime-workspace -os linux -ws gtk -arch x86
!ENTRY org.eclipse.core.runtime 2 1 Sep 06, 2002 09:52:20.202
!MESSAGE Problems encountered loading the plug-in registry.
!SUBENTRY 1 org.eclipse.core.runtime 2 1 Sep 06, 2002 09:52:20.203
!MESSAGE Unknown extension point "org.eclipse.team.core.fileTypes" specified in
plug-in "org.eclipse.jdt.core".
!SUBENTRY 1 org.eclipse.core.runtime 2 1 Sep 06, 2002 09:52:20.204
!MESSAGE Unknown extension point "org.eclipse.team.core.fileTypes" specified in
plug-in "org.eclipse.debug.core".
Comment 1 Philipe Mulet CLA 2002-09-30 06:16:40 EDT 
We only contribute recommendations for filetypes. So if VCM was present, then 
it would get these recommendations automatically, but we don't technically need 
VCM. However, the log entry is a little disturbing I admit.
Comment 2 Erich Gamma CLA 2002-09-30 07:55:39 EDT 
The way we do it works in the SDK case but has problems if the workspace is 
created with PDE based on the pre-reqs. Since there is no pre-req we will fail.

To avoid a hard dependency from JDT core on team and to still enable that PDE 
works we can declare team.core as an optional required plugin, e.g.,

	<requires>
	   <import plugin="xxx" optional=true/>
Comment 3 Philipe Mulet CLA 2002-10-02 10:11:57 EDT 
Wouldn't this result in us loading VCM on startup then ? If so, I am reluctant 
to cause some more activation...
Comment 4 Erich Gamma CLA 2002-10-14 10:11:42 EDT 
This wouldn't result in loading of the org.eclipse.team.core plugin on start-
up. The contributions we make go into the plugin registry only, this is the 
same behaviour as today

The price we pay is an additional pre-req on the plugins build path. Without 
some measurement of the effect on the start-up time it is not possible to 
estimate the cost. If the change has any performance cost then we should not 
make it. However, the log entry messages are scary during development and if 
there are no cost adding the pre-req as an optional plugin is benficial.
Comment 5 Philipe Mulet CLA 2002-10-14 10:56:57 EDT 
Agreed, but I guess that VCM would then be added on the buildpath of jdt/core, 
even though we strictly want to have no code dependency on it...

Scary for jdt/core developpers.
Deferring to M3
Comment 6 Philipe Mulet CLA 2002-10-15 05:13:57 EDT 
Reconsidering for M2. Adding optional plug-in dependency.
Fixed
Comment 7 David Audel CLA 2002-10-17 10:16:16 EDT 
Verified.