232706 – [Organize Manifest] "Mark as internal package" always done with *.internal* pattern

Bug 232706 - [Organize Manifest] "Mark as internal package" always done with *.internal* pattern

Summary: [Organize Manifest] "Mark as internal package" always done with *.internal* p...

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.4
Hardware:	All All

Importance:	P3 major (vote)
Target Milestone:	3.4 RC2
Assignee:	Benjamin Cabé
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2008-05-18 14:36 EDT by Benjamin Cabé
Modified:	2008-05-20 09:32 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Patch against o.e.pde.ui (2.71 KB, patch) 2008-05-18 14:39 EDT, Benjamin Cabé	no flags	Details \| Diff
mylyn/context/zip (879 bytes, application/octet-stream) 2008-05-18 14:39 EDT, Benjamin Cabé	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Benjamin Cabé

2008-05-18 14:36:33 EDT

+++ This bug was initially created as a clone of Bug #232693 +++

While investigating a bit for bug #232693, I got the very sad surprise to see that whatever pattern I used in the package field, the refactoring was always done with the default pattern (*.internal*).

There is no listener on the package text field and the attached patch will fix this odd issue.

Comment 1 Benjamin Cabé

2008-05-18 14:39:47 EDT

Created attachment 100831 [details]
Patch against o.e.pde.ui

Here it is

Comment 2 Benjamin Cabé

2008-05-18 14:39:51 EDT

Created attachment 100832 [details]
mylyn/context/zip

Comment 3 Benjamin Cabé

2008-05-18 14:52:22 EDT

Richard, you could be interested in this bug!

Comment 4 Chris Aniszczyk

2008-05-18 19:04:16 EDT

wow, nice catch

We will look at this in RC2

Comment 5 Benjamin Cabé

2008-05-19 16:12:17 EDT

If you want to, Chris, I can improve the patch a bit to perform a "setPageComplete(false)" when the input text is empty (that could be seen as a new feature however... even if this input text hasn't worked for years!)

Comment 6 Chris Aniszczyk

2008-05-20 09:31:47 EDT

good catch :)

> 20080520

Comment 7 Chris Aniszczyk

2008-05-20 09:32:16 EDT

you can open another bug for the other issue and just target for 3.5

We will survive for now :)