Bug 232616 - Label Decorators need updating
Summary: Label Decorators need updating
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords: PII
Depends on:
Blocks:
 
Reported: 2008-05-16 17:43 EDT by Nitin Dahyabhai CLA
Modified: 2008-05-23 05:14 EDT (History)
4 users (show)

See Also:
david_williams: pmc_approved+
cbridgha: pmc_approved? (raghunathan.srinivasan)
cbridgha: pmc_approved? (naci.dai)
cbridgha: pmc_approved? (deboer)
cbridgha: pmc_approved? (neil.hauge)
cbridgha: pmc_approved? (kaloyan)
cbridgha: review+
kaloyan: review+

Attachments
fixed short text and description of requested elements. (4.27 KB, patch)
2008-05-21 07:45 EDT, Dimitar Giormov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2008-05-16 17:43:31 EDT 
3.0M7 (and current builds)

On the General/Appearance/Label Decorations preference page, there are two entries that identify themselves as "Resource Decorator" with no descriptions.  I suspect they both come from Java EE:

org.eclipse.jst.j2ee.navigator.ui/plugin.properties:RESOURCE_DECORATOR=Resource Decorator
org.eclipse.jst.jee.ui/plugin.properties:RESOURCE_DECORATOR=Resource Decorator

The names should be unique and descriptions should be added.
Comment 1 Nitin Dahyabhai CLA 2008-05-16 17:46:37 EDT 
Also, the "Java EE Project Decorator" shows a description of "%jeeProjectDecorator.description" and there's one labeled as "BeanDecorator".
Comment 2 Carl Anderson CLA 2008-05-20 09:46:13 EDT 
Kaloyan, can we provide more meaningful titles?  Also, your team added the %jeeProjectDecorator.description to the plugin.xml, but a corresponding entry wasn't added to the plugin.properties- do you still have that content?
Comment 3 Kaloyan Raev CLA 2008-05-20 09:49:52 EDT 
Dimitar, could you take care for this?
Comment 4 Dimitar Giormov CLA 2008-05-21 07:45:54 EDT 
Created attachment 101227 [details]
fixed short text and description of requested elements.
Comment 5 Kaloyan Raev CLA 2008-05-21 08:47:25 EDT 
I am OK with these changes. 
Chuck, please have a review too, and request PMC approval for RC2, if you think this is important for 3.0.
Comment 6 Chuck Bridgham CLA 2008-05-21 16:46:14 EDT 
Simple safe fix for fit and finish
Comment 7 David Williams CLA 2008-05-22 01:34:28 EDT 
I believe some of the labels _might_ impact NL/tranlation efforts, so I've marked with PII ... please remove that key word, if I'm incorred.
Comment 8 Kaloyan Raev CLA 2008-05-22 08:43:27 EDT 
committed and released
Comment 9 Kaloyan Raev CLA 2008-05-23 05:14:01 EDT 
Verified with the S-3.0RC2-20080523002415 build.