Bug 232570 - API builder seems slower in I20080515-2000
Summary: API builder seems slower in I20080515-2000
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-05-16 14:52 EDT by Michael Rennie CLA
Modified: 2008-05-21 13:14 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+
darin.eclipse: review+

Attachments
Proposed fix (8.20 KB, patch)
2008-05-16 14:59 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (8.98 KB, patch)
2008-05-16 15:02 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2008-05-16 14:52:42 EDT 
Testing on Windows XP and Linux using I20080515-2000 it feels as though the API  builder is a bit slower. Talking with Olivier it could be that some additional time has been added with the fix for the @noreference support, where we now request the restrictions for each member.

It would be good to profile the builder again and compare...
Comment 1 Michael Rennie CLA 2008-05-16 14:56:25 EDT 
The related @noreference bug is bug 221923
Comment 2 Olivier Thomann CLA 2008-05-16 14:59:22 EDT 
Created attachment 100703 [details]
Proposed fix

This should improve the current situation where the baseline has no api description.
Comment 3 Olivier Thomann CLA 2008-05-16 15:02:11 EDT 
Created attachment 100704 [details]
Proposed fix

Forgot to handle the addition case.
Comment 4 Michael Rennie CLA 2008-05-16 15:16:31 EDT 
Patch speeds things up nicley, although the slow-down (albeit not that much) will occurr again once there are api descriptions in the builds.
Comment 5 Darin Wright CLA 2008-05-21 13:13:28 EDT 
+1. Applied.
Comment 6 Darin Wright CLA 2008-05-21 13:14:10 EDT 
Verified.