Bug 232445 - [reconciler] remove initial getCurrentProfile in reconciler.dropins Activator
Summary: [reconciler] remove initial getCurrentProfile in reconciler.dropins Activator
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-05-16 00:33 EDT by Simon Kaegi CLA
Modified: 2008-11-05 15:37 EST (History)
2 users (show)

See Also:

Attachments
patch (1.50 KB, patch)
2008-11-05 15:09 EST, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2008-05-16 00:33:57 EDT 
Getting the current profile is expensive and no longer needed here. We should remove this call and cleanup the watchDropins method to no longer require it.
Comment 1 DJ Houghton CLA 2008-11-05 15:09:16 EST 
Created attachment 117137 [details]
patch

I think that it is just a matter of removing the call. Simon can you think of any hiding problems here or should we just delete it?
Comment 2 Simon Kaegi CLA 2008-11-05 15:20:24 EST 
+1
Patch looks fine. I think if there are any problems the reconciler tests would catch them immediately. Also I'm not expecting any perf gain here though as the profile is cached albeit weakly.
Comment 3 DJ Houghton CLA 2008-11-05 15:37:32 EST 
Ok, thanks. I've released the patch to HEAD.