Bug 232294 - LatestIUVersionCollector refactoring and improvements
Summary: LatestIUVersionCollector refactoring and improvements
Status: RESOLVED DUPLICATE of bug 260105
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, performance
Depends on:
Blocks:
 
Reported: 2008-05-15 08:53 EDT by Pascal Rapicault CLA
Modified: 2009-01-07 12:21 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2008-05-15 08:53:10 EDT 
While reviewing the code I have noticed that the performance of LatestIUVersionCollector could be improved by overriding all the methods of Collector. 
Then this gives us the opportunity to bypass the backing list to which we have to add and remove the matching elements and just use the map we have to return all the results.
Comment 1 Pascal Rapicault CLA 2008-05-15 08:54:39 EDT 
We have 2 copies of this class and should strive to only have one.
Comment 2 Pascal Rapicault CLA 2009-01-07 12:21:39 EST 
Closing as dup since there is code change being discussed in bug #260105, and because we are also discussing finding a better place for it, there.

*** This bug has been marked as a duplicate of bug 260105 ***