Bug 232246 - [clean up] CleanUpPerfTest#testNullCleanUp does not create ASTs in 3.4
Summary: [clean up] CleanUpPerfTest#testNullCleanUp does not create ASTs in 3.4
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-05-15 04:46 EDT by Benno Baumgartner CLA
Modified: 2008-05-15 05:40 EDT (History)
1 user (show)

See Also:
martinae: review+


Attachments
Request ASTs (1.73 KB, patch)
2008-05-15 04:46 EDT, Benno Baumgartner CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2008-05-15 04:46:37 EDT
Created attachment 100381 [details]
Request ASTs

I20080513-2000

This test got broken by bug 153755: In 3.3. ASTs are created for each CU in 3.4 not anymore because the default clean up requirement does not require ASTs. That's why the test is very green: 789ms vs 21ms. I would like to fix this test, I need to know if AST creation has become slower, otherwise it's hard to make any statement about the other clean up performance test.
Comment 1 Benno Baumgartner CLA 2008-05-15 04:47:46 EDT
Martin? Is this OK?
Comment 2 Martin Aeschlimann CLA 2008-05-15 04:59:54 EDT
Ok, I think we don't need to approve changes in the tests.
Comment 3 Benno Baumgartner CLA 2008-05-15 05:40:52 EDT
fixed > I20080513-2000