Community
Participate
Working Groups
Created attachment 100070 [details] Patch to fix telnet connections TelnetConnector.java hides the protected ITerminalControl fControl field from the super class (TerminalConnectorImpl). Since the fControl field in TelnetConnector is never set, it remains NULL. When the getRemoteToTerminalOutputStream(), displayTextInTerminal(), or setState() methods are called an NPE is thrown. The effect is that a telnet connection can be opened but there is apparently no output from the host. This happens on Windows XP and Linux/GTK. It presumably happens on all platforms. A simple, one-line fix is attached.
Thanks for the patch, will consider for 3.0
That's a funny patch, contribution is exactly -1 lines of code. I'm wondering whether one can license a contribution that solely consists of removing stuff under the EPL? Removing the line of code is a creative act, so I'd certainly like adding you to the list of our contributors...
(In reply to comment #2) > That's a funny patch, contribution is exactly -1 lines of code. I'm wondering > whether one can license a contribution that solely consists of removing stuff > under the EPL? Removing the line of code is a creative act, so I'd certainly > like adding you to the list of our contributors... > Uh, OK -- seems kind of unnecessary, but I understand the legal need to name all contributors. What do I have to do to be added as a contributor?
I just applied the patch since this is really an obvious one. Thanks for the contribution, you are now an official TM contributor! http://www.eclipse.org/dsdp/tm/development/contributors.php
For reference and easier finding the issue, here's the Exception that's printed to the Error Log and also stdout: java.lang.NullPointerException at org.eclipse.tm.internal.terminal.telnet.TelnetConnector.getRemoteToTerminalOutputStream(TelnetConnector.java:136) at org.eclipse.tm.internal.terminal.telnet.TelnetConnection.run(TelnetConnection.java:322)
